amoghrajesh opened a new pull request, #38651:
URL: https://github.com/apache/airflow/pull/38651
Right now there is a limitation where the HiveOperator incorrectly parses
and constructs the beeline command if hive "high availability" url is given for
host. I was able to work
amoghrajesh commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1546123813
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -170,6 +178,10 @@ def _prepare_cli_cmd(self) -> list[Any]:
if ";" in proxy_user:
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2029434704
This is how the form looks now:
--
This is an automated message from t
romsharon98 commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2029518394
Looks good :)
Can u just add test with `proxy_user` in `extra_json` just to verify that it
add `;` correctly and to verify someone else not remove it.
--
This is an automated m
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2029586589
> Looks good :) Can u just add test with `proxy_user` in `extra_json` just
to verify that it add `;` correctly and to verify someone else not remove it.
Good catch! Updated th
eladkal commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1546303780
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -100,6 +100,9 @@ def __init__(
) -> None:
super().__init__()
conn = self.get_connection(h
amoghrajesh commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1547114486
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -100,6 +100,9 @@ def __init__(
) -> None:
super().__init__()
conn = self.get_connecti
potiuk commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1547805091
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -186,7 +195,13 @@ def _prepare_cli_cmd(self) -> list[Any]:
return [hive_bin, *cmd_extra, *hive_params_li
amoghrajesh commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1548055690
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -186,7 +195,13 @@ def _prepare_cli_cmd(self) -> list[Any]:
return [hive_bin, *cmd_extra, *hive_para
amoghrajesh commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1548055690
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -186,7 +195,13 @@ def _prepare_cli_cmd(self) -> list[Any]:
return [hive_bin, *cmd_extra, *hive_para
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2033657749
@potiuk @eladkal could you review this when you have some time? Or who would
be the right person for hive related PRs?
--
This is an automated message from the Apache Git Service.
hussein-awala commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1549113214
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -160,6 +162,9 @@ def _prepare_cli_cmd(self) -> list[Any]:
hive_bin = "beeline"
s
hussein-awala commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1549126122
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -100,6 +100,9 @@ def __init__(
) -> None:
super().__init__()
conn = self.get_connec
amoghrajesh commented on code in PR #38651:
URL: https://github.com/apache/airflow/pull/38651#discussion_r1549306722
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -160,6 +162,9 @@ def _prepare_cli_cmd(self) -> list[Any]:
hive_bin = "beeline"
sel
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2034004355
@hussein-awala I have addressed the nits as well, can you take a look if it
looks OK now?
--
This is an automated message from the Apache Git Service.
To respond to the messag
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2036692513
@potiuk @eladkal @hussein-awala if all looks good shall we send this one in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
amoghrajesh merged PR #38651:
URL: https://github.com/apache/airflow/pull/38651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airf
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2037396993
Merging this in favour of the reviews from Hussein and Elad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
18 matches
Mail list logo
