Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
potiuk merged PR #37172: URL: https://github.com/apache/airflow/pull/37172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
potiuk commented on code in PR #37172: URL: https://github.com/apache/airflow/pull/37172#discussion_r1478391758 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -1230,14 +1229,23 @@ def run_publish_docs_in_parallel( )

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
potiuk commented on code in PR #37172: URL: https://github.com/apache/airflow/pull/37172#discussion_r1478392828 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -1307,10 +1315,24 @@ def publish_docs( override_versioned=override_version

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
potiuk commented on code in PR #37172: URL: https://github.com/apache/airflow/pull/37172#discussion_r1478392441 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -1307,10 +1315,24 @@ def publish_docs( override_versioned=override_version

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
potiuk commented on code in PR #37172: URL: https://github.com/apache/airflow/pull/37172#discussion_r1478392055 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -1230,14 +1229,23 @@ def run_publish_docs_in_parallel( )

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
amoghrajesh commented on PR #37172: URL: https://github.com/apache/airflow/pull/37172#issuecomment-1927168578 Good feedback @potiuk this is how it looks now: (I am quite impressed actually) ``` (new-env) ➜ airflow git:(summaryPublishDocs) ✗ breeze release-management publish-doc

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
amoghrajesh commented on PR #37172: URL: https://github.com/apache/airflow/pull/37172#issuecomment-1927169952 Woops my bad, it has coloring. This is a screenshot ![image](https://github.com/apache/airflow/assets/35884252/cae45b3f-bc01-485b-855a-dd82cc3ad110) -- This is an automated

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-05 Thread via GitHub
amoghrajesh commented on PR #37172: URL: https://github.com/apache/airflow/pull/37172#issuecomment-1927152914 > Actually one thing should be changed. Rather than ysing print() you should use `get_console().print()` (and colors - `[success]` for published and `[warning]` for skipped + plus u

Re: [PR] Affixing exit summary to publish-docs command [airflow]

2024-02-04 Thread via GitHub
amoghrajesh commented on PR #37172: URL: https://github.com/apache/airflow/pull/37172#issuecomment-1926230332 Ask by @eladkal for ease of doc publishing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Affixing exit summary to publish-docs command [airflow]

2024-02-04 Thread via GitHub
amoghrajesh opened a new pull request, #37172: URL: https://github.com/apache/airflow/pull/37172 It would be nice to have a summary of the action all provider docs underwent at the end of `breeze publish-docs` command as it is super easy to miss the notes while publishing in