Re: [PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-11-10 Thread via GitHub
shahar1 commented on PR #34919: URL: https://github.com/apache/airflow/pull/34919#issuecomment-1805315325 LGTM :) @eladkal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-11-06 Thread via GitHub
atrbgithub commented on code in PR #34919: URL: https://github.com/apache/airflow/pull/34919#discussion_r1383668590 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -829,10 +829,12 @@ def _list( versions=versions, ) +all_b

Re: [PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-11-06 Thread via GitHub
atrbgithub commented on code in PR #34919: URL: https://github.com/apache/airflow/pull/34919#discussion_r1383622831 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -829,10 +829,12 @@ def _list( versions=versions, ) +all_b

Re: [PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-11-06 Thread via GitHub
shahar1 commented on code in PR #34919: URL: https://github.com/apache/airflow/pull/34919#discussion_r1383079555 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -829,10 +829,12 @@ def _list( versions=versions, ) +all_blob

Re: [PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-11-06 Thread via GitHub
shahar1 commented on code in PR #34919: URL: https://github.com/apache/airflow/pull/34919#discussion_r1383079555 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -829,10 +829,12 @@ def _list( versions=versions, ) +all_blob

Re: [PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-10-16 Thread via GitHub
atrbgithub commented on PR #34919: URL: https://github.com/apache/airflow/pull/34919#issuecomment-1764678627 Please see [here](https://github.com/googleapis/python-storage/issues/863#issuecomment-1245740122) for more info. In our case `blobs.prefixes` was not being populated.

[PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-10-13 Thread via GitHub
atrbgithub opened a new pull request, #34919: URL: https://github.com/apache/airflow/pull/34919 This fixes #34909 Performing the list of the blobs appears to force the blobs to be loaded rather than lazily loaded. --- **^ Add meaningful description abov