VelmiraPetkova opened a new pull request, #39465:
URL: https://github.com/apache/airflow/pull/39465
Allow FTPHook to use a custom FTP port number
closes: #39308
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
boring-cyborg[bot] commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2098726975
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
VelmiraPetkova commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2103337828
Yes, I'll do the test case over the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
vincbeck commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1599058827
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,11 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_connecti
VelmiraPetkova commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1600545687
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,11 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_co
VelmiraPetkova commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2110998707
I did some tests and fixed a tiny bug, when no port is supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vincbeck commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1600560171
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,11 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_connecti
amoghrajesh commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1602586766
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,14 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_conne
VelmiraPetkova commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1603978146
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,14 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_co
eladkal commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2132077581
@VelmiraPetkova can you please fix static checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
VelmiraPetkova commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2132210801
Sorry for the delay. I updated the PR. Could you please take a look? Thank
you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
eladkal commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1615691939
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -19,10 +19,12 @@
import datetime
import ftplib # nosec: B402
+import logging
from typing import Any, Callable
fr
eladkal commented on code in PR #39465:
URL: https://github.com/apache/airflow/pull/39465#discussion_r1615691939
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -19,10 +19,12 @@
import datetime
import ftplib # nosec: B402
+import logging
from typing import Any, Callable
fr
boring-cyborg[bot] commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2133237480
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
potiuk commented on PR #39465:
URL: https://github.com/apache/airflow/pull/39465#issuecomment-2133236880
The failing integration test case is a flake - mssql does not have enough
time to start. This has been fixed in #39866
--
This is an automated message from the Apache Git Service.
To
potiuk merged PR #39465:
URL: https://github.com/apache/airflow/pull/39465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
16 matches
Mail list logo