potiuk opened a new pull request, #37057:
URL: https://github.com/apache/airflow/pull/37057
In our process, we generally do not let the scripts in the "build images"
workflow to use `scripts/ci`, `dev` and `action` scripts to come from the PR.
This is a security feature that prevent Pull Re
potiuk commented on PR #37057:
URL: https://github.com/apache/airflow/pull/37057#issuecomment-1913594227
Once we merge that one, committers will have no more the problem that their
PRs modifying `dev` scripts will have to close it and re-open it from the
`apache` repository. It should **jus
hussein-awala commented on code in PR #37057:
URL: https://github.com/apache/airflow/pull/37057#discussion_r1468865093
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1039,3 +1040,9 @@ def providers_compatibility_checks(self) -> str:
if check[
potiuk commented on code in PR #37057:
URL: https://github.com/apache/airflow/pull/37057#discussion_r1468866371
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1039,3 +1040,9 @@ def providers_compatibility_checks(self) -> str:
if check["python
potiuk commented on code in PR #37057:
URL: https://github.com/apache/airflow/pull/37057#discussion_r1468868060
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1039,3 +1040,9 @@ def providers_compatibility_checks(self) -> str:
if check["python
potiuk commented on code in PR #37057:
URL: https://github.com/apache/airflow/pull/37057#discussion_r1468880404
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1039,3 +1040,9 @@ def providers_compatibility_checks(self) -> str:
if check["python
potiuk commented on PR #37057:
URL: https://github.com/apache/airflow/pull/37057#issuecomment-1913626242
I will do some more testing in my own fork, to see if I have everything
righ.
And I'd appreciate a bit more thorough review for that one. This is a
sensitive part of our actions
potiuk commented on PR #37057:
URL: https://github.com/apache/airflow/pull/37057#issuecomment-1913692464
All right I did some testing and applied a few smal fixes (optimiized away
the checkout for target-branch for commiter build as it turned out to be not
needed
For anyone looking h
potiuk commented on code in PR #37057:
URL: https://github.com/apache/airflow/pull/37057#discussion_r1468921710
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1039,3 +1040,9 @@ def providers_compatibility_checks(self) -> str:
if check["python
potiuk merged PR #37057:
URL: https://github.com/apache/airflow/pull/37057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
hussein-awala commented on code in PR #37057:
URL: https://github.com/apache/airflow/pull/37057#discussion_r1468931589
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1039,3 +1040,9 @@ def providers_compatibility_checks(self) -> str:
if check[
hussein-awala commented on PR #37057:
URL: https://github.com/apache/airflow/pull/37057#issuecomment-1913711280
Well done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
potiuk commented on PR #37057:
URL: https://github.com/apache/airflow/pull/37057#issuecomment-1914380272
cc: @ephraimbuddy FYI -> this is something I wil cherry-pick shortly
(together with other recent refactors) to v2-8-test and do some testing if it
works as expected (there are some small
13 matches
Mail list logo
