ephraimbuddy commented on code in PR #35250:
URL: https://github.com/apache/airflow/pull/35250#discussion_r1447723745
##
airflow/cli/commands/dag_command.py:
##
@@ -362,15 +374,16 @@ def dag_list_dags(args) -> None:
"For details, run `airflow dags
jtmiclat commented on PR #35250:
URL: https://github.com/apache/airflow/pull/35250#issuecomment-1883051952
Hi @sidrahsayyad I haven't worked on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sidrahsayyad commented on PR #35250:
URL: https://github.com/apache/airflow/pull/35250#issuecomment-1882528154
Hi @jtmiclat you've mentioned 'Note: Will have a follow up pr to minimize
database calls', was that done as well ?
--
This is an automated message from the Apache Git Service.
boring-cyborg[bot] commented on PR #35250:
URL: https://github.com/apache/airflow/pull/35250#issuecomment-1880203250
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional
potiuk merged PR #35250:
URL: https://github.com/apache/airflow/pull/35250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jtmiclat commented on PR #35250:
URL: https://github.com/apache/airflow/pull/35250#issuecomment-1787437058
Merged the suggestions and fixed the tests !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Lee-W commented on code in PR #35250:
URL: https://github.com/apache/airflow/pull/35250#discussion_r1377126833
##
airflow/cli/commands/dag_command.py:
##
@@ -351,8 +351,20 @@ def print_execution_interval(interval: DataInterval |
None):
@cli_utils.action_cli
jtmiclat commented on code in PR #35250:
URL: https://github.com/apache/airflow/pull/35250#discussion_r1376560830
##
airflow/cli/commands/dag_command.py:
##
@@ -351,8 +351,16 @@ def print_execution_interval(interval: DataInterval |
None):
@cli_utils.action_cli
Lee-W commented on code in PR #35250:
URL: https://github.com/apache/airflow/pull/35250#discussion_r1376017092
##
airflow/cli/commands/dag_command.py:
##
@@ -351,8 +351,16 @@ def print_execution_interval(interval: DataInterval |
None):
@cli_utils.action_cli
jtmiclat commented on PR #35250:
URL: https://github.com/apache/airflow/pull/35250#issuecomment-1784432516
@hussein-awala Thank you for your comments!
I think both are good suggestions and pushed some changes to reflect them.
1. I changed the parameter to just columns with
10 matches
Mail list logo