Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-04-05 Thread via GitHub
Taragolis merged PR #38373: URL: https://github.com/apache/airflow/pull/38373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-26 Thread via GitHub
Taragolis commented on PR #38373: URL: https://github.com/apache/airflow/pull/38373#issuecomment-2019847029 Nice, could you also add tests when the new parameters provided, this might help to avoid some kind regression in the future -- This is an automated message from the Apache Git Serv

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-23 Thread via GitHub
collinmcnulty commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1536720963 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **s

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
collinmcnulty commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1534128777 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **s

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
collinmcnulty commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1534127749 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **s

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
Taragolis commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1534036807 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **self.

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
Taragolis commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1534036807 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **self.

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
Taragolis commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1534015849 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **self.

Re: [PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
Taragolis commented on code in PR #38373: URL: https://github.com/apache/airflow/pull/38373#discussion_r1534003589 ## airflow/providers/samba/hooks/samba.py: ## @@ -245,10 +245,22 @@ def setxattr(self, path, attribute, value, flags=0, follow_symlinks=True): **self.

[PR] Allow specification of buffer length for GCS to Samba [airflow]

2024-03-21 Thread via GitHub
collinmcnulty opened a new pull request, #38373: URL: https://github.com/apache/airflow/pull/38373 Previously, the SambaHook and therefore the GCSToSambaOperator did not allow changing the buffer length used to copy the files to Samba. This lead to very long upload times for