hterik opened a new pull request, #34887:
URL: https://github.com/apache/airflow/pull/34887
Previously, if user set dag_run_id parameter in the url, that refers to a
old run, which doesn't fit in the most recent 25 runs, then the requested run
will not be selected.
This change fixes
sinwoobang commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1802300696
This bug significantly impacts the efficiency of navigating DagRuns,
particularly when dealing with a high volume of items. The ability to quickly
identify a specific DagRun is criti
sinwoobang commented on code in PR #34887:
URL: https://github.com/apache/airflow/pull/34887#discussion_r1392614238
##
airflow/www/views.py:
##
@@ -3467,25 +3468,44 @@ def grid_data(self):
if num_runs is None:
num_runs = conf.getint("webserver",
"default_d
hterik commented on code in PR #34887:
URL: https://github.com/apache/airflow/pull/34887#discussion_r1392647818
##
airflow/www/views.py:
##
@@ -3467,25 +3468,44 @@ def grid_data(self):
if num_runs is None:
num_runs = conf.getint("webserver",
"default_dag_r
sinwoobang commented on code in PR #34887:
URL: https://github.com/apache/airflow/pull/34887#discussion_r1392931525
##
airflow/www/views.py:
##
@@ -3467,25 +3468,44 @@ def grid_data(self):
if num_runs is None:
num_runs = conf.getint("webserver",
"default_d
hterik commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1811942748
@ryanahamilton @ashb @bbovenzi @pierrejeambrun can you please help in
reviewing or find someone else who can review this?
This has been pending for some time now and fixes a very a
hterik commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1818390814
> I don't see why we need a custom context provider. I would prefer we try
to have a `useEffect` inside of `useGridData` to detect only the first time
`runId` is specified in the url par
bbovenzi commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1819160336
> > I don't see why we need a custom context provider. I would prefer we try
to have a `useEffect` inside of `useGridData` to detect only the first time
`runId` is specified in the url
bbovenzi commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1830785350
1. Do you mind rebasing?
2. Can we change the base date in the UI as well? Otherwise there is no way
in the UI to reset the selection and get to the most recent dag runs.
--
T
hterik commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1831229595
Is it possible to take the base date changes separately as an improvement?
This bug makes the most recent versions of airflow completely unusable for us,
would be great to have some kind
bbovenzi commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1832384351
> Is it possible to take the base date changes separately as an improvement?
This bug makes the most recent versions of airflow completely unusable for us,
would be great to have some
hterik commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1833492307
Rebased now.
I see the problem with base date now. The whole base date selector and the
filter options stop working if a `dag_run_id` was present in the URL (though
`dag_run_id` i
bbovenzi commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1856537227
@hterik Ok I'm happy to clean up this filters+main logic. Mind to rebase the
PR first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ephraimbuddy commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1890961758
There's conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
eladkal commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1948287425
@hterik Can you handle the rebase and resolve conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jscheffl commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1953238610
Yeah, would be great - as this fix was pushed multiple times... next release
will be cut in ~24h - if rebased and reviewed the chance is likely to get it
in...
--
This is an automat
bbovenzi merged PR #34887:
URL: https://github.com/apache/airflow/pull/34887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
bbovenzi commented on code in PR #34887:
URL: https://github.com/apache/airflow/pull/34887#discussion_r1496547257
##
airflow/www/views.py:
##
@@ -3465,25 +3466,42 @@ def grid_data(self):
if num_runs is None:
num_runs = conf.getint("webserver",
"default_dag
hterik commented on code in PR #34887:
URL: https://github.com/apache/airflow/pull/34887#discussion_r1356736539
##
airflow/www/views.py:
##
@@ -3465,25 +3466,42 @@ def grid_data(self):
if num_runs is None:
num_runs = conf.getint("webserver",
"default_dag_r
jens-scheffler-bosch commented on PR #34887:
URL: https://github.com/apache/airflow/pull/34887#issuecomment-1787550600
I tried my best to review this PR but I was not able to get the UI running
with breeze locally. GRID view did not show up anymore. Unfortunately I'm not
really a TypeScript
20 matches
Mail list logo
