[PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-10-29 Thread via GitHub
syun64 opened a new pull request, #35256: URL: https://github.com/apache/airflow/pull/35256 I believe that there may be a bug where if a partial_subset dag is generated on a DAG with `on_success_callback` or `on_failure_callback` functions defined on it, then it might try to

Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-10-30 Thread via GitHub
Lee-W commented on code in PR #35256: URL: https://github.com/apache/airflow/pull/35256#discussion_r1375999496 ## airflow/models/dag.py: ## @@ -1428,6 +1428,13 @@ def fetch_callback( dagrun = DAG.fetch_dagrun(dag_id=dag.dag_id, run_id=dag_run_id, session=session)

Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-10-31 Thread via GitHub
syun64 commented on code in PR #35256: URL: https://github.com/apache/airflow/pull/35256#discussion_r1377747632 ## airflow/models/dag.py: ## @@ -1428,6 +1428,13 @@ def fetch_callback( dagrun = DAG.fetch_dagrun(dag_id=dag.dag_id, run_id=dag_run_id, session=session)

Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-11-06 Thread via GitHub
syun64 commented on PR #35256: URL: https://github.com/apache/airflow/pull/35256#issuecomment-1795207176 Thank you for the review @vincbeck . Would you be able to merge this in? Unfortunately I do not have write access to the repository -- This is an automated message from the Apache Git

Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-11-06 Thread via GitHub
vincbeck merged PR #35256: URL: https://github.com/apache/airflow/pull/35256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-11-06 Thread via GitHub
vincbeck commented on PR #35256: URL: https://github.com/apache/airflow/pull/35256#issuecomment-1795301895 Done! Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co