hussein-awala commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479019308
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,21 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_lat
potiuk commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479018788
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,20 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
hussein-awala commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479017382
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,20 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_lat
potiuk commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479017367
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,21 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
potiuk commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479017718
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,21 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
potiuk commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479017010
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,21 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
hussein-awala commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1479015583
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,21 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_lat
ninsbl commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1478928304
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,20 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
potiuk commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1478921486
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,20 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
ninsbl commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1477051165
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,20 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_late:
+
ninsbl commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1925268233
Hope adding the exception for `acks` in
[8419527](https://github.com/apache/airflow/pull/37066/commits/841952715dcbe36fb21e93fac1d0e5d588eccbae)
was correct resolution for the failing sp
ninsbl commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1922420520
Hmm, it seems the spell checking does ot like the new key name:
(`
Incorrect Spelling: 'acks'
Line with Error: 'task_acks_late'
`)...
--
This is an automated message fro
ninsbl commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1922297044
Anything I can do to move this forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ninsbl commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1918729936
> Yes. Yu need to rebase and rerun it to fix it. Breeze /tests works for
sure in latest main.
Thanks, @potiuk , I can confirm that breeze now builds and runs fine after
rebase...
potiuk commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1918677407
I rebased this one and added PR to make future local build work in case we
have not managed to refresh the constraints yet
https://github.com/apache/airflow/pull/37116 - that will take l
potiuk commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1918650473
> BTW.: When running tests with breeze (on WSL2) I get the following error
message:
>
> This does not prevent unittests from being executed though...
Yes. Yu need to rebase
ninsbl commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1917698973
> I just checked the conversation in the original issue, and personally I
prefer to keep the default value to True and waits for community feedback
before deciding if we need to change i
hussein-awala commented on PR #37066:
URL: https://github.com/apache/airflow/pull/37066#issuecomment-1917645760
I just checked the conversation in the original issue, and personally I
prefer to keep the default value to True and waits for community feedback
before deciding if we need to cha
hussein-awala commented on code in PR #37066:
URL: https://github.com/apache/airflow/pull/37066#discussion_r1471747200
##
airflow/providers/celery/provider.yaml:
##
@@ -276,6 +276,20 @@ config:
type: float
example: ~
default: "1.0"
+ task_acks_lat
ninsbl opened a new pull request, #37066:
URL: https://github.com/apache/airflow/pull/37066
Celery
[task_acks_late](https://docs.celeryq.dev/en/stable/userguide/configuration.html#task-acks-late)
is currently hard-coded to be deactivated. However, this causes issues when
ta
20 matches
Mail list logo
