Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2023-12-25 Thread via GitHub
pankajkoti commented on code in PR #36416: URL: https://github.com/apache/airflow/pull/36416#discussion_r1436303356 ## airflow/providers/amazon/aws/operators/redshift_cluster.py: ## @@ -535,19 +535,27 @@ def execute(self, context: Context): time.sleep(self._

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2023-12-26 Thread via GitHub
Lee-W commented on code in PR #36416: URL: https://github.com/apache/airflow/pull/36416#discussion_r1436405148 ## airflow/providers/amazon/aws/operators/redshift_cluster.py: ## @@ -535,19 +535,27 @@ def execute(self, context: Context): time.sleep(self._attem

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2023-12-26 Thread via GitHub
pankajkoti commented on code in PR #36416: URL: https://github.com/apache/airflow/pull/36416#discussion_r1436423823 ## airflow/providers/amazon/aws/operators/redshift_cluster.py: ## @@ -714,26 +738,41 @@ def execute(self, context: Context): time.sleep(self._

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2023-12-26 Thread via GitHub
pankajkoti commented on code in PR #36416: URL: https://github.com/apache/airflow/pull/36416#discussion_r1436423521 ## airflow/providers/amazon/aws/operators/redshift_cluster.py: ## @@ -535,19 +535,29 @@ def execute(self, context: Context): time.sleep(self._

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2023-12-27 Thread via GitHub
Lee-W commented on code in PR #36416: URL: https://github.com/apache/airflow/pull/36416#discussion_r1437323931 ## airflow/providers/amazon/aws/operators/redshift_cluster.py: ## @@ -624,25 +637,36 @@ def execute(self, context: Context): else:

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2024-01-02 Thread via GitHub
vincbeck commented on PR #36416: URL: https://github.com/apache/airflow/pull/36416#issuecomment-1874432619 Same comment as #36523, I am not sure we want to do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2024-01-02 Thread via GitHub
Lee-W commented on PR #36416: URL: https://github.com/apache/airflow/pull/36416#issuecomment-1874797410 > Same comment as #36523, I am not sure we want to do that Replied in https://github.com/apache/airflow/pull/36523#issuecomment-1874715083 -- This is an automated message from th

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2024-01-05 Thread via GitHub
Lee-W commented on PR #36416: URL: https://github.com/apache/airflow/pull/36416#issuecomment-1879521457 @pankajkoti Please let me know if there's any other concern on this PR when you're available. Thanks! -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Check redshift cluster state before deferring to triggerer [airflow]

2024-01-06 Thread via GitHub
potiuk merged PR #36416: URL: https://github.com/apache/airflow/pull/36416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a