Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-22 Thread via GitHub
bbovenzi merged PR #37580: URL: https://github.com/apache/airflow/pull/37580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-22 Thread via GitHub
bbovenzi commented on PR #37580: URL: https://github.com/apache/airflow/pull/37580#issuecomment-1960103817 @jedcunningham For some reason `test_user_defined_filter_and_macros_raise_error` is failing, but it doesn't failed if GET `rendered-templates` still has `@action_logging`... -- Thi

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-22 Thread via GitHub
bbovenzi commented on PR #37580: URL: https://github.com/apache/airflow/pull/37580#issuecomment-1959897068 > Specifically `test_action_logging_get_legacy_view` seems directly relevant. Fixed. Removed two unneeded tests and added a test for robots.txt -- This is an automated message

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
uranusjr commented on PR #37580: URL: https://github.com/apache/airflow/pull/37580#issuecomment-1958847389 Specifically `test_action_logging_get_legacy_view` seems directly relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
jedcunningham commented on PR #37580: URL: https://github.com/apache/airflow/pull/37580#issuecomment-1958710658 Looks like there might be a couple test failures from this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1498448602 ## airflow/www/views.py: ## @@ -3737,7 +3709,6 @@ def datasets_summary(self): ) @expose("/robots.txt") -@action_logging Review Comment: F

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
jedcunningham commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1498441335 ## airflow/www/views.py: ## @@ -3737,7 +3709,6 @@ def datasets_summary(self): ) @expose("/robots.txt") -@action_logging Review Comment:

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1498298441 ## airflow/config_templates/config.yml: ## @@ -1831,7 +1831,7 @@ webserver: version_added: 2.3.0 type: string example: ~ - default: "gantt

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
vincbeck commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1497778187 ## airflow/config_templates/config.yml: ## @@ -1831,7 +1831,7 @@ webserver: version_added: 2.3.0 type: string example: ~ - default: "gantt

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
amoghrajesh commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1497059915 ## airflow/config_templates/config.yml: ## @@ -1831,7 +1831,7 @@ webserver: version_added: 2.3.0 type: string example: ~ - default: "ga

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-20 Thread via GitHub
bbovenzi commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1496865632 ## airflow/config_templates/config.yml: ## @@ -1831,7 +1831,7 @@ webserver: version_added: 2.3.0 type: string example: ~ - default: "gantt

[PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-20 Thread via GitHub
bbovenzi opened a new pull request, #37580: URL: https://github.com/apache/airflow/pull/37580 Clean up when we actually want to log events. Remove a few other unused decorators, mostly on on redirect functions. --- **^ Add meaningful description above** Read the **[Pull Requ