Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
potiuk merged PR #38188: URL: https://github.com/apache/airflow/pull/38188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
potiuk commented on code in PR #38188: URL: https://github.com/apache/airflow/pull/38188#discussion_r1527167022 ## tests/conftest.py: ## @@ -36,6 +37,34 @@ assert "airflow" not in sys.modules, "No airflow module can be imported before these lines" +# Clear all Environment

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
Taragolis commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2001971293 A bit hacky solution but I keep add simple configurations for extend, remove. I'm more and more think that we have create `pytest` plugin for better control all our different config

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
Taragolis commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2001970614 And it's green now 😺 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
Taragolis commented on code in PR #38188: URL: https://github.com/apache/airflow/pull/38188#discussion_r1527149757 ## tests/conftest.py: ## @@ -36,6 +37,34 @@ assert "airflow" not in sys.modules, "No airflow module can be imported before these lines" +# Clear all Environme

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
Taragolis commented on code in PR #38188: URL: https://github.com/apache/airflow/pull/38188#discussion_r1527149848 ## tests/conftest.py: ## @@ -36,6 +37,34 @@ assert "airflow" not in sys.modules, "No airflow module can be imported before these lines" +# Clear all Environme

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-16 Thread via GitHub
potiuk commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2001883882 Nice :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-15 Thread via GitHub
Taragolis commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2000751567 Well only integrations with kerberos remaining. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-15 Thread via GitHub
Taragolis commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2000605405 I expects a bit more failures TBH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-15 Thread via GitHub
Taragolis commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2000590823 > I think it will clean too much As far as I could see it just failed on celery, and broker URI (AIRFLOW__CELERY__BROKER_URL) which somewhere hardcoded to `redis://redis:6379/0

Re: [PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-15 Thread via GitHub
potiuk commented on PR #38188: URL: https://github.com/apache/airflow/pull/38188#issuecomment-2000579758 I think it will clean `too much` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] Cleanup Airflow Configurations environment variables before run the tests [airflow]

2024-03-15 Thread via GitHub
Taragolis opened a new pull request, #38188: URL: https://github.com/apache/airflow/pull/38188 Developers usual use breeze environment for the different purposes: check something in airflow, run tests, etc. Also for configuration it is pretty common to use `/files/airflow