potiuk commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1869809630
LGTM as an approach. My proposal will be to replace the whole Role if it is
already defined with the new one coming from the. import. I wonder if we
should backwards compatibility and a
vincbeck merged PR #36347:
URL: https://github.com/apache/airflow/pull/36347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
gbonazzoli commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1874987058
@dominikhei
I've just tested on my installation and it works !
There is only a little aesthetic inaccuracy as you can see form the `airflow
roles export `output:
potiuk commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1874989352
> I looked at the code and I think we have the same problem also in the
import phase.
Good chance to make a PR and fix it @gbonazzoli
--
This is an automated message from the A
gbonazzoli commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875002765
@potiuk @dominikhei
Unfortunately I'm not a developer and I'm not able to make the PR (git
commands and count distinct "name" attribute in the Python list are among the
thing
potiuk commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875006072
> Unfortunately I'm not a developer and I'm not able to make the PR (git
commands and count distinct "name" attribute in the Python list are among the
things that I do not know how to wr
potiuk commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875458389
And BTW, if you don't want to - then I suggest you create an issue - then we
can mark it as good-first-issue and make it ready for someone to pick it up.
Comment in PR is not really acti
vincbeck commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875529189
By looking at this PR again, the json format changes, is not it a breaking
change? If some users use the CI command `airflow roles export` or `airflow
roles import` in their CI, it wil
vincbeck commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875550552
To fix the test: #36558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
potiuk commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875558733
> By looking at this PR again, the json format changes, is not it a breaking
change?
The observation we had is that we should treat it as bugfix. Roles
export/import without permi
vincbeck commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875563625
Sounds good :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gbonazzoli commented on PR #36347:
URL: https://github.com/apache/airflow/pull/36347#issuecomment-1876671832
@potiuk @vincbeck @dominikhei
#36580 created with the title: Cli export / import roles including
permissions Part 2 (refinement)
--
This is an automated message from the Ap
12 matches
Mail list logo
