[PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-22 Thread via GitHub
potiuk opened a new pull request, #35801: URL: https://github.com/apache/airflow/pull/35801 Historically (when moved from Bash) the environment variables set for docker or docker-compose commands were set in a few places - some were set directly in the code, some were retrieved from shell p

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-22 Thread via GitHub
potiuk commented on PR #35801: URL: https://github.com/apache/airflow/pull/35801#issuecomment-1823147340 This is a small follow-up after #35768 - this time not about --build-arg generation by breeze but about env variables passed to docker-compose/docker. The way it was done was quite a bit

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-22 Thread via GitHub
potiuk commented on PR #35801: URL: https://github.com/apache/airflow/pull/35801#issuecomment-1823148752 BTW, I am going to separate out small part of it - fixes to pre-commit attempting to upgrade itself in a few pre-commits (which slowed them down and made it impossible to run them in the

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-22 Thread via GitHub
potiuk commented on PR #35801: URL: https://github.com/apache/airflow/pull/35801#issuecomment-1823158812 There you go : https://github.com/apache/airflow/pull/35802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-22 Thread via GitHub
potiuk commented on PR #35801: URL: https://github.com/apache/airflow/pull/35801#issuecomment-1823165942 BTW. This one will make it SO MUCH EASIER to understand and add new variables if we need to :) -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-22 Thread via GitHub
potiuk commented on PR #35801: URL: https://github.com/apache/airflow/pull/35801#issuecomment-1823216669 Some celery URL passing problem - will take a look tomorrow :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-23 Thread via GitHub
potiuk commented on PR #35801: URL: https://github.com/apache/airflow/pull/35801#issuecomment-1824049973 Actually - I made it even better (see the latest version). I also figured how to do it so that we do not have to keep the separate lists of variables to pass in neither docker-compose ba

Re: [PR] Consolidate environment variable calculation in ShellParams in Breeze [airflow]

2023-11-23 Thread via GitHub
potiuk merged PR #35801: URL: https://github.com/apache/airflow/pull/35801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a