Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2024-03-20 Thread via GitHub
vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1532079650 ## airflow/models/taskinstance.py: ## @@ -1692,69 +2411,14 @@ def signal_handler(signum, frame): Stats.incr("operator_successes", tags={**self.stats_tags, "

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2024-03-20 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1531673185 ## airflow/models/taskinstance.py: ## @@ -1692,69 +2411,14 @@ def signal_handler(signum, frame): Stats.incr("operator_successes", tags={**self.stats_tags, "ta

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2024-03-15 Thread via GitHub
vandonr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1526277558 ## airflow/models/taskinstance.py: ## @@ -1692,69 +2411,14 @@ def signal_handler(signum, frame): Stats.incr("operator_successes", tags={**self.stats_tags, "t

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2024-03-15 Thread via GitHub
vandonr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1526276182 ## airflow/models/taskinstance.py: ## @@ -375,6 +379,795 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance, conte

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2023-12-17 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1429319698 ## airflow/models/dag.py: ## @@ -1383,8 +1384,43 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_interv

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2023-12-17 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1429319698 ## airflow/models/dag.py: ## @@ -1383,8 +1384,43 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_interv

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2023-12-17 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1429319698 ## airflow/models/dag.py: ## @@ -1383,8 +1384,43 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_interv

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2023-12-12 Thread via GitHub
vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1424467194 ## airflow/models/dag.py: ## @@ -1383,8 +1384,43 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

Re: [PR] Convert DagFileProcessor.execute_callbacks to Internal API [airflow]

2023-12-11 Thread via GitHub
dstandish commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1423410165 ## airflow/models/dag.py: ## @@ -1383,8 +1384,43 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_int