vincbeck opened a new pull request, #35926:
URL: https://github.com/apache/airflow/pull/35926
As a result of the [lazy
consensus](https://lists.apache.org/thread/o457svvnsn4xdnb7j79jyqsxvldj6qmz),
this PR creates a new provider: fab. This new provider contains (and should
always only conta
ferruzzi commented on code in PR #35926:
URL: https://github.com/apache/airflow/pull/35926#discussion_r1409879281
##
.pre-commit-config.yaml:
##
@@ -525,6 +524,7 @@ repos:
^airflow/providers/apache/spark/hooks/|
^airflow/providers/apache/spark/operators/|
vincbeck commented on code in PR #35926:
URL: https://github.com/apache/airflow/pull/35926#discussion_r1410830201
##
setup.cfg:
##
@@ -103,6 +103,7 @@ install_requires =
# NOTE! When you change the value here, you also have to update
flask-appbuilder[oauth] in setup.py
vincbeck commented on code in PR #35926:
URL: https://github.com/apache/airflow/pull/35926#discussion_r1410831443
##
.pre-commit-config.yaml:
##
@@ -525,6 +524,7 @@ repos:
^airflow/providers/apache/spark/hooks/|
^airflow/providers/apache/spark/operators/|
vincbeck closed pull request #35926: Create FAB provider and move FAB auth
manager in it
URL: https://github.com/apache/airflow/pull/35926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ferruzzi commented on code in PR #35926:
URL: https://github.com/apache/airflow/pull/35926#discussion_r1412478458
##
airflow/providers/fab/auth_manager/security_manager/override.py:
##
@@ -2150,7 +2150,7 @@ def get_oauth_user_info(self, provider: str, resp:
dict[str, Any]) -> d
ferruzzi commented on code in PR #35926:
URL: https://github.com/apache/airflow/pull/35926#discussion_r1412478458
##
airflow/providers/fab/auth_manager/security_manager/override.py:
##
@@ -2150,7 +2150,7 @@ def get_oauth_user_info(self, provider: str, resp:
dict[str, Any]) -> d
eladkal commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1836644788
I may be late to the party but...
is `fab` the right name?
Shouldn't it be the official name `FlaskAppBuilder` ?
--
This is an automated message from the Apache Git Service.
vincbeck commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1836649635
> I may be late to the party but... is `fab` the right name? Shouldn't it be
the official name `FlaskAppBuilder` ?
I am not strongly opinionated but since we are already using ab
vincbeck commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1840975216
CI is green :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1847948444
🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1848320351
Woooh. Compat tests passed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
vincbeck commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1850356286
The build prod image fails again with the latest changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
vincbeck commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1850364946
When doing the merge, I removed [this
line](https://github.com/apache/airflow/pull/35926/commits/8f1b089af16f06cd372304d185ba0565ec32b3f5#diff-9a3861f568f7701950cbeaec9b46fbafb8f39ccbfa
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1850399011
Nope. It was https://github.com/apache/airflow/pull/36168 - rebase and it
should be gone (and my PR also added different behaviour when constraint
generation will fail - it will fail at
vincbeck commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1850656418
CLI is green! (thanks @potiuk for the help!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
vincbeck merged PR #35926:
URL: https://github.com/apache/airflow/pull/35926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1850674253
Wooh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
ephraimbuddy commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1857442327
I think this move should have been part of 2.8.0. Another option would be to
release it as part of 2.8.1 because if there's any bug on FAB that needs fixing
in 2.8, we won't be abl
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1857583281
> I think this move should have been part of 2.8.0. Another option would be
to release it as part of 2.8.1 because if there's any bug on FAB that needs
fixing in 2.8, we won't be able to
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1857583864
I am happy to do those cherry-picks, if it makes things easier :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
eladkal commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1857853466
> I am happy to do those cherry-picks, if it makes things easier :)
Can this PR be cherry picked to 2.8 branch?
It changed import path in existed migration script
`airflow/migr
ephraimbuddy commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1857875064
> > I am happy to do those cherry-picks, if it makes things easier :)
>
> Can this PR be cherry picked to 2.8 branch? It changed import path in
existed migration script
`air
potiuk commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1857955842
We can also revert this one and keep a PR open and merge it when we get
closer to 2.9.0 - that's also an option @vincbeck ?
--
This is an automated message from the Apache Git Service.
vincbeck commented on PR #35926:
URL: https://github.com/apache/airflow/pull/35926#issuecomment-1858049455
We can just fix the bug in 2.8 branch and then cherry-pick/apply this change
to `main` (or all the way around). I think this is the easiest. Adding this PR
to 2.8 is a bit too late IMO
25 matches
Mail list logo
