Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

eladkal commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1447825928 ## airflow/providers/google/cloud/triggers/kubernetes_engine.py: ## @@ -25,6 +25,7 @@ from google.cloud.container_v1.types import Operation from airflow.exception

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

hussein-awala commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1447830148 ## airflow/providers/google/cloud/triggers/kubernetes_engine.py: ## @@ -25,6 +25,7 @@ from google.cloud.container_v1.types import Operation from airflow.exc

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

eladkal commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1885520418 Also doc paragraph about this new cool ability is good to have -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

hussein-awala commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1885943230 @eladkal could you check the Google provider check? is it's complicated, I can bump the min `cncf-kubernetes` version to avoid this complexity. -- This is an automated message f

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

hussein-awala commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1451020122 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -550,7 +561,17 @@ def execute_sync(self, context: Context): # get remote pod for use

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

hussein-awala commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1451020561 ## airflow/providers/google/provider.yaml: ## @@ -151,7 +151,7 @@ additional-extras: - apache-beam[gcp] - name: cncf.kubernetes dependencies: -

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

eladkal commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1451719498 ## airflow/providers/google/provider.yaml: ## @@ -151,7 +151,7 @@ additional-extras: - apache-beam[gcp] - name: cncf.kubernetes dependencies: - -

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

potiuk commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1451789690 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -550,7 +561,17 @@ def execute_sync(self, context: Context): # get remote pod for use in cle

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

potiuk commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1451790580 ## airflow/providers/google/provider.yaml: ## @@ -151,7 +151,7 @@ additional-extras: - apache-beam[gcp] - name: cncf.kubernetes dependencies: - - a

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

potiuk commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1891050408 There is a test failure though :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

hussein-awala commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1901447474 I just tested on a real cluster and found that the type I provide to the trigger is converted to a string. I even tried providing an object instance but had the same problem. That

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

hussein-awala merged PR #35714: URL: https://github.com/apache/airflow/pull/35714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai