vincbeck commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1863017152
#36175 updated the interface and I dont think it is in 2.8. To me, this was
the last interface modification and since then, the auth manager interface is
solid and should not change
potiuk commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1862841628
I marked it as 2.8.1 for now @vincbeck -> do you feel that the Auth Manager
interface in 2.8 is solid enough to bring the docs update to 2.8.1 and expose
to the users? or do you think it
potiuk merged PR #36211:
URL: https://github.com/apache/airflow/pull/36211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1862827520
> Ci is green! I had to revert references to the fab provider because Sphinx
does not like referencing in flight documents. I'll create another PR when this
one gets merged to essentiall
vincbeck commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1861823434
Ci is green! I had to revert references to the fab provider because Sphinx
does not like referencing in flight documents. I'll create another PR when this
one gets merged to essentiall
vincbeck commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856225351
Creating diagrams is actually super fun! I experienced a bug though. When I
run the script as is, everything is fine but when I generate the diagrams
through the static checks (`breeze
vincbeck commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856213983
> Sphinx speaking riddles again
>
> I will take a look after my talk (I have a talk at https://osacon.io in 45
minutes so a little stressed ;) .
Thank you :D! And good luc
potiuk commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856211195
Sphinx speaking riddles again
I will take a look after my talk (I have a talk at https://osacon.io in 45
minutes so a little stressed ;) .
--
This is an automated message from
vincbeck commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856206101
In the meantime, do you know why it is complaining about
`sphinx.errors.SphinxWarning:
/opt/airflow/docs/apache-airflow/security/api.rst:24:unknown document:
'apache-airflow-prov
potiuk commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856113825
BTW. You can run the pre-comit script "as-is" - as long as you have diagrams
installed in your venv it works as regular Python script
--
This is an automated message from the Apache Gi
potiuk commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856112440
> Sounds exciting! Let me try that
Indeed, I love how they implemented it and it's really nice to iterate on
diagram, it's super-fast- just change the code, run the pre-commit and
vincbeck commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1856046976
> Comment/ Proposal. Why don't you prepare one/two diagrams, similar to the
ones that you had in the AIP. I recently integrated the nice Python "Diagram as
a Code" tool into our pre-co
potiuk commented on PR #36211:
URL: https://github.com/apache/airflow/pull/36211#issuecomment-1855988839
Comment/ Proposal. Why don't you prepare one/two diagrams, similar to the
ones that you had in the AIP. I recently integrated the nice Python "Diagram as
a Code" tool into our pre-commit
vincbeck commented on code in PR #36211:
URL: https://github.com/apache/airflow/pull/36211#discussion_r1425787375
##
docs/apache-airflow/core-concepts/auth-manager.rst:
##
@@ -0,0 +1,174 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
vincbeck commented on code in PR #36211:
URL: https://github.com/apache/airflow/pull/36211#discussion_r1425786315
##
docs/apache-airflow/core-concepts/auth-manager.rst:
##
@@ -0,0 +1,174 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
vincbeck commented on code in PR #36211:
URL: https://github.com/apache/airflow/pull/36211#discussion_r1425784702
##
docs/apache-airflow/core-concepts/auth-manager.rst:
##
@@ -0,0 +1,174 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
vincbeck commented on code in PR #36211:
URL: https://github.com/apache/airflow/pull/36211#discussion_r1425779312
##
docs/apache-airflow-providers-fab/auth-manager/index.rst:
##
@@ -18,4 +18,13 @@
Fab auth manager
Review Comment:
That's good point
--
This is an automate
o-nikolas commented on code in PR #36211:
URL: https://github.com/apache/airflow/pull/36211#discussion_r1425751100
##
docs/apache-airflow/core-concepts/auth-manager.rst:
##
@@ -0,0 +1,174 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
vincbeck commented on code in PR #36211:
URL: https://github.com/apache/airflow/pull/36211#discussion_r1425655767
##
docs/apache-airflow-providers-fab/auth-manager/api-authentication.rst:
##
@@ -0,0 +1,137 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+o
vincbeck opened a new pull request, #36211:
URL: https://github.com/apache/airflow/pull/36211
Create some documentation about the concept of auth manager. Explain as well
how to create a new auth manager. Add documentation as well for the FAB auth
manager. I also moved some pages and sectio
20 matches
Mail list logo
