Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
bolkedebruin commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425624595 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
potiuk commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425425660 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Transf

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425397577 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Tr

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425397577 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Tr

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
potiuk commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425365162 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Transf

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
phanikumv commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425336524 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Tra

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
utkarsharma2 commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425309132 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
utkarsharma2 commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425309132 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
utkarsharma2 commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425309132 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
utkarsharma2 commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425309132 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""

Re: [PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1853837572 @Joffreybvn -> do you have more things to add to it or you think it's ready to review ? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] Databricks sql hook returns json-serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
Joffreybvn opened a new pull request, #36205: URL: https://github.com/apache/airflow/pull/36205 This PR fixes https://github.com/apache/airflow/pull/36161#pullrequestreview-1779199804 NamedTuple can be used as a tuple or a dict. [databricks.Row](https://github.com/databricks/databric