Re: [PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

Taragolis commented on code in PR #39690: URL: https://github.com/apache/airflow/pull/39690#discussion_r1605365262 ## tests/providers/common/sql/hooks/test_dbapi.py: ## @@ -421,6 +421,56 @@ def test_get_uri_without_auth_and_empty_host(self): ) assert self.db_ho

Re: [PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

dabla commented on code in PR #39690: URL: https://github.com/apache/airflow/pull/39690#discussion_r1605280393 ## tests/providers/common/sql/hooks/test_dbapi.py: ## @@ -421,6 +421,56 @@ def test_get_uri_without_auth_and_empty_host(self): ) assert self.db_hook.g

Re: [PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

dabla commented on code in PR #39690: URL: https://github.com/apache/airflow/pull/39690#discussion_r1605260210 ## tests/providers/common/sql/hooks/test_dbapi.py: ## @@ -421,6 +421,56 @@ def test_get_uri_without_auth_and_empty_host(self): ) assert self.db_hook.g

Re: [PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

dabla commented on code in PR #39690: URL: https://github.com/apache/airflow/pull/39690#discussion_r1605260210 ## tests/providers/common/sql/hooks/test_dbapi.py: ## @@ -421,6 +421,56 @@ def test_get_uri_without_auth_and_empty_host(self): ) assert self.db_hook.g

Re: [PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

dabla commented on code in PR #39690: URL: https://github.com/apache/airflow/pull/39690#discussion_r1605260210 ## tests/providers/common/sql/hooks/test_dbapi.py: ## @@ -421,6 +421,56 @@ def test_get_uri_without_auth_and_empty_host(self): ) assert self.db_hook.g

Re: [PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

Taragolis commented on code in PR #39690: URL: https://github.com/apache/airflow/pull/39690#discussion_r1605218668 ## tests/providers/common/sql/hooks/test_dbapi.py: ## @@ -421,6 +421,56 @@ def test_get_uri_without_auth_and_empty_host(self): ) assert self.db_ho

[PR] DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is correct if invalid [airflow]

dabla opened a new pull request, #39690: URL: https://github.com/apache/airflow/pull/39690 This PR fixes an invalid warning message being logged when placeholder is None (and thus not defined in the connection extra field) and also makes sure that when the placeholder isn't