dstandish commented on code in PR #33718:
URL: https://github.com/apache/airflow/pull/33718#discussion_r1773558243
##
airflow/models/baseoperator.py:
##
@@ -1600,7 +1601,10 @@ def resume_execution(self, next_method: str,
next_kwargs: dict[str, Any] | None,
tracebac
dstandish commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2371582212
> We need to keep this active and gain consistency.
Ok @nathadfield I just rebased. I pinged @hussein-awala to pick the comment
thread back up. If you could review the open co
dstandish commented on code in PR #33718:
URL: https://github.com/apache/airflow/pull/33718#discussion_r1773554065
##
airflow/sensors/base.py:
##
@@ -285,6 +286,8 @@ def run_duration() -> float:
def resume_execution(self, next_method: str, next_kwargs: dict[str, Any] |
Non
nathadfield commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2370450444
We need to keep this active and gain consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2369824131
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
kaxil commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2274453418
Ping @dstandish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dstandish opened a new pull request, #33718:
URL: https://github.com/apache/airflow/pull/33718
Alternative to https://github.com/apache/airflow/pull/32990
resolves https://github.com/apache/airflow/issues/32638
This is a less invasive approach. Essentially, what we do here is,
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2272967475
This is still an open issue that needs to be addressed for consistency
between deferrable and non-deferrable sensors.
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] closed pull request #33718: Deferrable sensors can timeout
with no retries
URL: https://github.com/apache/airflow/pull/33718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dstandish commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2021039197
> @dstandish I had tested this out on Jan 29 2024 and left the feedback in
the comment above - [#33718
(comment)](https://github.com/apache/airflow/pull/33718#issuecomment-1914788890)
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2020984126
@dstandish I had tested this out on Jan 29 2024 and left the feedback in the
comment above -
https://github.com/apache/airflow/pull/33718#issuecomment-1914788890. I see
there's now a
dstandish commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2020964764
@robg-eb were you able to test this locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2002711347
@dstandish - I'd hate to see this PR get closed as we seemed to be on the
right track here , and the issue still exists around this inconsistent behavior
with deferrable sensors. Any
github-actions[bot] commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-2002673729
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1914788890
@dstandish and team - Thank you for creating this PR, as we are currently
unable to properly use retries with Deferrable (Async) sensors, because of the
inconsistency in retry / timeout
nathadfield commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1887337460
I just raised [this](https://github.com/apache/airflow/issues/36734) issue
but, it looks like it is covered by this PR.
--
This is an automated message from the Apache Git Service
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1881109501
We want to keep this PR active - I can test this week as needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1879887816
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
dstandish commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1822858057
> @dstandish - To clarify, is this PR ready to test as-is?
Right.
In short what this does is, now when trigger times out we raise
TaskDeferralTimeout instead of the gen
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1822836815
@dstandish - To clarify, is this PR ready to test as-is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dstandish commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1822833012
> @dstandish and team - I see this issue was auto-closed and now reopened.
My team is struggling with the same issue, so we'd be happy to help/test in any
way possible as needed - let
dstandish commented on code in PR #33718:
URL: https://github.com/apache/airflow/pull/33718#discussion_r1402113003
##
airflow/models/baseoperator.py:
##
@@ -1600,7 +1601,10 @@ def resume_execution(self, next_method: str,
next_kwargs: dict[str, Any] | None,
tracebac
robg-eb commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1795045195
@dstandish and team - I see this issue was auto-closed and now reopened. My
team is struggling with the same issue, so we'd be happy to help/test in any
way possible as needed - let us
dstandish opened a new pull request, #33718:
URL: https://github.com/apache/airflow/pull/33718
Alternative to https://github.com/apache/airflow/pull/32990
resolves https://github.com/apache/airflow/issues/32638
This is a less invasive approach. Essentially, what we do here is,
github-actions[bot] closed pull request #33718: Deferrable sensors can timeout
with no retries
URL: https://github.com/apache/airflow/pull/33718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
github-actions[bot] commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1762413696
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
26 matches
Mail list logo
