potiuk commented on PR #38015:
URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041529236
> If we can add the newsfragtment on the docs this woul dbe great for others
potentially stumbling into it.
Agree :)
--
This is an automated message from the Apache Git
jscheffl commented on PR #38015:
URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041524410
Thanks @potiuk for the detailled background. Convinced.
And believe me, I did not want to revert and call for an RC4 - if we can add
the newsfragtment on the docs this woul dbe great
potiuk commented on PR #38015:
URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041517914
I think a little bit more context is needed on that one, becuase this is a
follow-up and really fix of another problem introdued in 2.8 in
https://github.com/apache/airflow/pull/33430 (
jscheffl commented on PR #38015:
URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041348474
Uh, oh, late to the party. I noticed this change which - after some reading
- really looks understandable. But when testing 2.9.0RC2 I had a lot of broken
DAGs and it felt to be like a
boring-cyborg[bot] commented on PR #38015:
URL: https://github.com/apache/airflow/pull/38015#issuecomment-2015977471
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
potiuk merged PR #38015:
URL: https://github.com/apache/airflow/pull/38015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
kevinalh commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1527170374
##
airflow/decorators/base.py:
##
@@ -208,11 +208,35 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're
uranusjr commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1521948279
##
airflow/decorators/base.py:
##
@@ -208,11 +208,35 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're
uranusjr commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1521947442
##
tests/decorators/test_python.py:
##
@@ -259,6 +259,16 @@ def add_number(num: int) -> int:
add_number()
add_number("test")
+def test_fa
uranusjr commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1521946748
##
airflow/decorators/base.py:
##
@@ -208,11 +208,35 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're
kevinalh commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1520710330
##
airflow/decorators/base.py:
##
@@ -208,11 +208,36 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're
Taragolis commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1519372994
##
airflow/decorators/base.py:
##
@@ -208,11 +208,36 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we'r
kevinalh commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1518928827
##
airflow/decorators/base.py:
##
@@ -208,11 +208,25 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're
kevinalh commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1518928827
##
airflow/decorators/base.py:
##
@@ -208,11 +208,25 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're
potiuk commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1518758684
##
airflow/decorators/base.py:
##
@@ -208,11 +208,25 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're n
potiuk commented on code in PR #38015:
URL: https://github.com/apache/airflow/pull/38015#discussion_r1518758684
##
airflow/decorators/base.py:
##
@@ -208,11 +208,25 @@ def __init__(
# since values for those will be provided when the task is run. Since
# we're n
16 matches
Mail list logo
