Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-29 Thread via GitHub
dirrao commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1914902451 @potiuk I have fixed rest of the issues. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-29 Thread via GitHub
potiuk commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1914645261 Main reason being this: ![image](https://github.com/apache/airflow/assets/595491/59d26e44-58af-45bf-ab03-a087f51bd7f2) -- This is an automated message from the Apache Git Se

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-29 Thread via GitHub
potiuk commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1914642292 You need to rebase and regenerate the deps @dirrao :+1: > There is a need to regenerate /home/runner/work/airflow/airflow/generated/provider_dependencies.json You need to run t

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-29 Thread via GitHub
potiuk commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1914271525 Looks like output of some tests is different than expected with the upgraded client (which is somewhat expected) - either the tests should be fixed or some of the "real" code updated.

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-29 Thread via GitHub
potiuk commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1914267443 Seems there are some errors to fix though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-28 Thread via GitHub
potiuk commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1913519658 Protection against such manual updates here: https://github.com/apache/airflow/pull/37052 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-28 Thread via GitHub
potiuk commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1913513257 The problem was that you manually modified the `provider_dependencies.json" file and did not modify `pyproject.toml` (they are both generated from provider.yaml being the single source o

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-27 Thread via GitHub
dirrao commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1913149355 > `#52 25.79 The conflict is caused by: [7496](https://github.com/apache/airflow/actions/runs/7676485430/job/20924456098?pr=37040#step:7:7567) #52 25.79 apache-airflow-providers-cncf-kub

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-27 Thread via GitHub
hussein-awala commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1913107394 Close and reopen to run all the tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-27 Thread via GitHub
hussein-awala closed pull request #37040: Draft: kubernetes version bump URL: https://github.com/apache/airflow/pull/37040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Draft: kubernetes version bump [airflow]

2024-01-27 Thread via GitHub
dirrao commented on PR #37040: URL: https://github.com/apache/airflow/pull/37040#issuecomment-1913084786 @potiuk Prod image build failing due to user constraints. How to update the user constraints file and test? -- This is an automated message from the Apache Git Service. To respond

[PR] Draft: kubernetes version bump [airflow]

2024-01-26 Thread via GitHub
dirrao opened a new pull request, #37040: URL: https://github.com/apache/airflow/pull/37040 close: #36678 extension: #36684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme