AchimGaedkeLynker opened a new pull request, #36828:
URL: https://github.com/apache/airflow/pull/36828
This PR implements the termination of instances in creation when a task
instance is stopped (externally marked for retry) before the instance IDs were
returned. It uses the `on_kill` metho
AchimGaedkeLynker commented on PR #36828:
URL: https://github.com/apache/airflow/pull/36828#issuecomment-1894882544
> Can you add the test cases for this?
Absolutely, I just have to find out how to test `on_kill`... It's on my
todo list, any pointers?
--
This is an automated messa
vincbeck commented on PR #36828:
URL: https://github.com/apache/airflow/pull/36828#issuecomment-1896244392
> > Can you add the test cases for this?
>
> Absolutely, I just have to find out how to test `on_kill`... It's on my
todo list. Will dig into the AWS mock setup...
You can
syedahsn commented on code in PR #36828:
URL: https://github.com/apache/airflow/pull/36828#discussion_r1456470327
##
airflow/providers/amazon/aws/operators/ec2.py:
##
@@ -183,22 +183,36 @@ def execute(self, context: Context):
MaxCount=self.max_count,
**
AchimGaedkeLynker commented on code in PR #36828:
URL: https://github.com/apache/airflow/pull/36828#discussion_r1456505130
##
airflow/providers/amazon/aws/operators/ec2.py:
##
@@ -183,22 +183,36 @@ def execute(self, context: Context):
MaxCount=self.max_count,
AchimGaedkeLynker commented on code in PR #36828:
URL: https://github.com/apache/airflow/pull/36828#discussion_r1456505130
##
airflow/providers/amazon/aws/operators/ec2.py:
##
@@ -183,22 +183,36 @@ def execute(self, context: Context):
MaxCount=self.max_count,
AchimGaedkeLynker commented on code in PR #36828:
URL: https://github.com/apache/airflow/pull/36828#discussion_r1456505130
##
airflow/providers/amazon/aws/operators/ec2.py:
##
@@ -183,22 +183,36 @@ def execute(self, context: Context):
MaxCount=self.max_count,
syedahsn commented on code in PR #36828:
URL: https://github.com/apache/airflow/pull/36828#discussion_r1457843632
##
airflow/providers/amazon/aws/operators/ec2.py:
##
@@ -183,22 +183,36 @@ def execute(self, context: Context):
MaxCount=self.max_count,
**
vincbeck merged PR #36828:
URL: https://github.com/apache/airflow/pull/36828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
