ferruzzi merged PR #37786:
URL: https://github.com/apache/airflow/pull/37786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1513228620
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1513228620
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
syedahsn commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1512019507
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
syedahsn commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1512015893
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1511964756
##
tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py:
##
@@ -829,6 +830,45 @@ def test_update_running_tasks_failed(self, mock_executor,
caplog):
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1511726812
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
syedahsn commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1511721803
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1508383523
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "name
o-nikolas commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1508221874
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -493,3 +496,39 @@ def get_container(self, container_list):
'container "nam
ferruzzi commented on PR #37786:
URL: https://github.com/apache/airflow/pull/37786#issuecomment-1971724758
@eladkal - You had some comments in the previous attempt at this, you may
want to have eyes on this one.
--
This is an automated message from the Apache Git Service.
To respond to th
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1508010742
##
tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py:
##
@@ -829,6 +830,45 @@ def test_update_running_tasks_failed(self, mock_executor,
caplog):
dirrao commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1506962210
##
tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py:
##
@@ -829,6 +830,45 @@ def test_update_running_tasks_failed(self, mock_executor,
caplog):
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1506930993
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -85,30 +85,30 @@ class RunTaskKwargsConfigKeys(BaseConfigKeys):
ASSIGN_PUBLIC_IP = "assign_public_
ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1506930794
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -85,30 +85,30 @@ class RunTaskKwargsConfigKeys(BaseConfigKeys):
ASSIGN_PUBLIC_IP = "assign_public_
ferruzzi opened a new pull request, #37786:
URL: https://github.com/apache/airflow/pull/37786
### Depends on and blocked by https://github.com/apache/airflow/pull/37784
Once the external_executor_id bug is fixed, this will add the feature to
adopt abandoned tasks in the ECS Executor.
ferruzzi closed pull request #36803: ECS Executor - add support to adopt
orphaned tasks.
URL: https://github.com/apache/airflow/pull/36803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ferruzzi commented on PR #36803:
URL: https://github.com/apache/airflow/pull/36803#issuecomment-1967596864
Unless anyone here feels strongly otherwise, I think I'm going to close this
one and open a new PR. It's been a while and it needs a rebase, plus there are
now a few commits which can
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1466752754
##
airflow/jobs/scheduler_job_runner.py:
##
@@ -721,6 +721,7 @@ def _process_executor_events(self, session: Session) -> int:
if state == TaskInstanceSta
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1464091003
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
o-nikolas commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1463881273
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1462634293
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
ferruzzi commented on PR #36803:
URL: https://github.com/apache/airflow/pull/36803#issuecomment-1904882892
Accidentally did a rebase and ingested the bug fixed by
https://github.com/apache/airflow/pull/36958, re-rebased so CI should clear now.
--
This is an automated message from the Apac
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1462362234
##
airflow/jobs/scheduler_job_runner.py:
##
@@ -721,6 +721,7 @@ def _process_executor_events(self, session: Session) -> int:
if state == TaskInstanceSta
o-nikolas commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1462245406
##
airflow/jobs/scheduler_job_runner.py:
##
@@ -721,6 +721,7 @@ def _process_executor_events(self, session: Session) -> int:
if state == TaskInstanceSt
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1454173463
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1454127274
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1453979230
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1453967270
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1453962858
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] ==
eladkal commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1453854872
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -470,3 +481,43 @@ def get_container(self, container_list):
if container["name"] == s
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1452838930
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -82,22 +83,23 @@ class RunTaskKwargsConfigKeys(BaseConfigKeys):
ASSIGN_PUBLIC_IP = "assign_public_
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1452838564
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -46,6 +46,7 @@
"assign_public_ip": "False",
"platform_version": "LATEST",
"check_health_
ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1452838564
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -46,6 +46,7 @@
"assign_public_ip": "False",
"platform_version": "LATEST",
"check_health_
ferruzzi opened a new pull request, #36803:
URL: https://github.com/apache/airflow/pull/36803
Adds support for "adopt orphaned tasks" to the ECS Executor.
A task can become orphaned, for example, when the scheduler container is
re-deployed or terminated or other cases where the Sche
35 matches
Mail list logo
