potiuk merged PR #37502:
URL: https://github.com/apache/airflow/pull/37502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1499058987
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -93,6 +93,17 @@ in `src/airflow_breeze/utils/packages.py` and run the
`prepare-provider-document
command with the `
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1499056022
##
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##
@@ -640,6 +640,13 @@ def build_docs(
for directory in docs_dir.rglob(dir_name):
amoghrajesh commented on PR #37502:
URL: https://github.com/apache/airflow/pull/37502#issuecomment-1958671254
@potiuk @eladkal just fixed the build docs and failing checks and also
rebased. Should be green now hopefully!
--
This is an automated message from the Apache Git Service.
To resp
potiuk commented on PR #37502:
URL: https://github.com/apache/airflow/pull/37502#issuecomment-1957003022
Yeah. And conflicts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
amoghrajesh commented on PR #37502:
URL: https://github.com/apache/airflow/pull/37502#issuecomment-1956982324
@potiuk @eladkal Can you take a look when you have some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
amoghrajesh commented on PR #37502:
URL: https://github.com/apache/airflow/pull/37502#issuecomment-1951957811
Oops, image needed to see color coding
--
This is an automated message fro
amoghrajesh commented on PR #37502:
URL: https://github.com/apache/airflow/pull/37502#issuecomment-1951956814
@potiuk handled the review comments. An example of the error case when both
the environment variable as well as individual arguments are passed to the
command. I am publishing a war
amoghrajesh commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494150124
##
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##
@@ -640,6 +640,13 @@ def build_docs(
for directory in docs_dir.rglob(dir_name):
amoghrajesh commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494149620
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -493,6 +510,13 @@ cd "${AIRFLOW_REPO_ROOT}"
breeze build-docs apache-airflow-providers cncf.kubernetes sftp --c
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494088517
##
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##
@@ -640,6 +640,13 @@ def build_docs(
for directory in docs_dir.rglob(dir_name):
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494088517
##
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##
@@ -640,6 +640,13 @@ def build_docs(
for directory in docs_dir.rglob(dir_name):
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494089005
##
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##
@@ -640,6 +640,13 @@ def build_docs(
for directory in docs_dir.rglob(dir_name):
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494075462
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -493,6 +510,13 @@ cd "${AIRFLOW_REPO_ROOT}"
breeze build-docs apache-airflow-providers cncf.kubernetes sftp --clean-
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494075799
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -493,6 +510,13 @@ cd "${AIRFLOW_REPO_ROOT}"
breeze build-docs apache-airflow-providers cncf.kubernetes sftp --clean-
potiuk commented on code in PR #37502:
URL: https://github.com/apache/airflow/pull/37502#discussion_r1494075462
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -493,6 +510,13 @@ cd "${AIRFLOW_REPO_ROOT}"
breeze build-docs apache-airflow-providers cncf.kubernetes sftp --clean-
amoghrajesh commented on PR #37502:
URL: https://github.com/apache/airflow/pull/37502#issuecomment-1951655532
@eladkal can you take a look at this PR when you have some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
17 matches
Mail list logo
