akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385583643
##
docs/apache-airflow-providers-papermill/connections/jupyter_kernel.rst:
##
@@ -0,0 +1,78 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
akshaychitneni commented on PR #34840:
URL: https://github.com/apache/airflow/pull/34840#issuecomment-1800116172
> I think you still need to fix [Static
Checks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#static-code-checks),
most of them fixed by run `pre-commit` hoo
bolkedebruin merged PR #34840:
URL: https://github.com/apache/airflow/pull/34840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
boring-cyborg[bot] commented on PR #34840:
URL: https://github.com/apache/airflow/pull/34840#issuecomment-1807969418
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
Taragolis commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1352033233
##
airflow/providers/papermill/operators/__init__.py:
##
@@ -15,3 +15,8 @@
# KIND, either express or implied. See the License for the
# specific language governi
eladkal commented on PR #34840:
URL: https://github.com/apache/airflow/pull/34840#issuecomment-1756951119
> The situation around Papermill is not good, this provider might be
suspended in the future (or even soon), see:
Yes but in the meantime we can accept PRs
--
This is an automa
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1359945002
##
airflow/providers/papermill/operators/papermill.py:
##
@@ -20,14 +20,97 @@
from typing import TYPE_CHECKING, ClassVar, Collection, Sequence
import attr
akshaychitneni commented on PR #34840:
URL: https://github.com/apache/airflow/pull/34840#issuecomment-1763496404
> The situation around Papermill is not good, this provider might be
suspended in the future (or even soon), see:
>
> * Comment [Remove Airflow 2.3 compat from `PapermillOp
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1359945595
##
airflow/providers/papermill/operators/__init__.py:
##
@@ -15,3 +15,8 @@
# KIND, either express or implied. See the License for the
# specific language go
akshaychitneni commented on PR #34840:
URL: https://github.com/apache/airflow/pull/34840#issuecomment-1771862604
@Taragolis @eladkal Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Taragolis commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1371356084
##
airflow/providers/papermill/provider.yaml:
##
@@ -44,6 +44,7 @@ dependencies:
- apache-airflow>=2.5.0
- papermill[all]>=1.2.1
- scrapbook[all]
+ - ipyk
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r138535
##
airflow/providers/papermill/hooks/kernel.py:
##
@@ -0,0 +1,48 @@
+from airflow.hooks.base import BaseHook
+
+JUPYTER_KERNEL_SHELL_PORT = 60316
+JUPYTER_KERN
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385345068
##
airflow/providers/papermill/hooks/kernel.py:
##
@@ -0,0 +1,48 @@
+from airflow.hooks.base import BaseHook
+
+JUPYTER_KERNEL_SHELL_PORT = 60316
+JUPYTER_KERN
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385345845
##
airflow/providers/papermill/provider.yaml:
##
@@ -44,6 +44,7 @@ dependencies:
- apache-airflow>=2.5.0
- papermill[all]>=1.2.1
- scrapbook[all]
+ -
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385347118
##
airflow/providers/papermill/operators/papermill.py:
##
@@ -17,17 +17,102 @@
# under the License.
from __future__ import annotations
+from functools impo
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385347383
##
airflow/providers/papermill/hooks/kernel.py:
##
@@ -0,0 +1,48 @@
+from airflow.hooks.base import BaseHook
+
+JUPYTER_KERNEL_SHELL_PORT = 60316
+JUPYTER_KERN
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385348078
##
airflow/providers/papermill/hooks/kernel.py:
##
@@ -0,0 +1,48 @@
+from airflow.hooks.base import BaseHook
+
+JUPYTER_KERNEL_SHELL_PORT = 60316
+JUPYTER_KERN
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385350302
##
airflow/providers/papermill/operators/papermill.py:
##
@@ -17,17 +17,102 @@
# under the License.
from __future__ import annotations
+from functools impo
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385350796
##
airflow/providers/papermill/operators/papermill.py:
##
@@ -17,17 +17,102 @@
# under the License.
from __future__ import annotations
+from functools impo
akshaychitneni commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385350060
##
airflow/providers/papermill/operators/papermill.py:
##
@@ -17,17 +17,102 @@
# under the License.
from __future__ import annotations
+from functools impo
akshaychitneni commented on PR #34840:
URL: https://github.com/apache/airflow/pull/34840#issuecomment-1799399454
@Taragolis Thanks for your comments and suggestions. I have updated by PR to
address your feedback. Please take a look.
--
This is an automated message from the Apache Git Serv
Taragolis commented on code in PR #34840:
URL: https://github.com/apache/airflow/pull/34840#discussion_r1385465404
##
docs/apache-airflow-providers-papermill/connections/jupyter_kernel.rst:
##
@@ -0,0 +1,78 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+
22 matches
Mail list logo
