jedcunningham merged PR #41109:
URL: https://github.com/apache/airflow/pull/41109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
jedcunningham commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696901831
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) ->
jedcunningham commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696900146
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) ->
wolfier commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696354408
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) -> None:
potiuk commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696285950
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) -> None:
jedcunningham opened a new pull request, #41109:
URL: https://github.com/apache/airflow/pull/41109
When trying to complete adopted pods, if we encounter an ApiException, we
should assume we were unable to adopt the pod meaning we shouldn't add that to
our `running` set. If we do, `running`
