[PR] Fix AzureContainerInstanceOperator remove_on_error [airflow]

2023-10-27 Thread via GitHub
danielvdende opened a new pull request, #35212: URL: https://github.com/apache/airflow/pull/35212 --- The `remove_on_error` parameter of the `AzureContainerInstanceOperator` was not working as intended. When set to `False` it should only skip the removal of the Azure Container Group

Re: [PR] Fix AzureContainerInstanceOperator remove_on_error [airflow]

2023-11-08 Thread via GitHub
eladkal merged PR #35212: URL: https://github.com/apache/airflow/pull/35212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Fix AzureContainerInstanceOperator remove_on_error [airflow]

2023-10-29 Thread via GitHub
eladkal commented on PR #35212: URL: https://github.com/apache/airflow/pull/35212#issuecomment-1784439635 Can you please add unit test to cover this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix AzureContainerInstanceOperator remove_on_error [airflow]

2023-11-01 Thread via GitHub
danielvdende commented on PR #35212: URL: https://github.com/apache/airflow/pull/35212#issuecomment-1788664811 @eladkal I just added 1 test and updated an existing one to cover this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log