maiconkkl opened a new pull request, #36437:
URL: https://github.com/apache/airflow/pull/36437
related: #36432
The exception raised Your CUSTOM_SECURITY_MANAGER must extend
FabAirflowSecurityManagerOverride, not FAB's own security manager.
My English is not good, so I ask you to b
boring-cyborg[bot] commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1869588628
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
potiuk commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1869649485
I think the intention here was a bit different and I'd wait for @vincbeck to
come back from holidays to merge this one. There were a few changes to the
structure of the Auth Manager clas
maiconkkl commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1869652338
> I think the intention here was a bit different and I'd wait for @vincbeck
to come back from holidays to merge this one. There were a few changes to the
structure of the Auth Manager
potiuk commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1869656502
Not really. We are cherry-picking some changes from main to be released in
2.8.* - these are bug-fixes and doc updates mostly - so.I'd say this (and doc
changes) should go to 2.8.1. it
DjVinnii commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1870432714
I'm also running into the related issue, so a fix will be great as it is now
blocking us to upgrade to Airflow 2.8. To me the proposed fix should do the
trick as the raised error indic
potiuk commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1870450698
> I'm also running into the related issue, so a fix will be great as it is
now blocking us to upgrade to Airflow 2.8. To me the proposed fix should do the
trick as the raised error indic
potiuk commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1870451711
This is a beauty of Open-Source software. You can ALWAYS patch things while
waiting for a more complete ifx. And rushing fixes without having a full
knowledge is often bad idea. Go slow
maiconkkl commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874364103
> I am against this change.
>
> What is the value of `SECURITY_MANAGER_CLASS` in your scenario? There is
something weird because this check was already there before we migrated
vincbeck commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874385253
Happy new year too @maiconkkl. Thanks for all the details and indeed there
is a bug. This is related to #36343 as well. I just figured out the bug, let me
create a PR for it. I'll expl
vincbeck commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874394749
See #36538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
vincbeck commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874395446
@maiconkkl if you could pull the changes of this PR locally and do some
testing on your end, that would be very appreciated :)
--
This is an automated message from the Apache Git Ser
maiconkkl commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874419943
> @maiconkkl if you could pull the changes of this PR locally and do some
testing on your end, that would be very appreciated :)
I already tested it and it works well for me
-
vincbeck commented on PR #36437:
URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874423322
> > @maiconkkl if you could pull the changes of this PR locally and do some
testing on your end, that would be very appreciated :)
>
> I already tested it and it works well for m
maiconkkl closed pull request #36437: Fix Exception
FabAirflowSecurityManagerOverride
URL: https://github.com/apache/airflow/pull/36437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
15 matches
Mail list logo
