Re: [PR] Fix KPO docs argument precedence [airflow]

2024-02-06 Thread via GitHub
eladkal merged PR #37047: URL: https://github.com/apache/airflow/pull/37047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-02-06 Thread via GitHub
amoghrajesh commented on PR #37047: URL: https://github.com/apache/airflow/pull/37047#issuecomment-1930100941 Okay we finally have a green CI. Shall we send this in @potiuk ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-02-04 Thread via GitHub
ketozhang commented on code in PR #37047: URL: https://github.com/apache/airflow/pull/37047#discussion_r1477605769 ## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ## @@ -77,8 +77,8 @@ You can print out the Kubernetes manifest for the pod that would be created at

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-02-02 Thread via GitHub
potiuk commented on PR #37047: URL: https://github.com/apache/airflow/pull/37047#issuecomment-1923766672 fix to bactics is needed. RST does not like single backticks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-02-01 Thread via GitHub
dirrao commented on code in PR #37047: URL: https://github.com/apache/airflow/pull/37047#discussion_r1475580760 ## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ## @@ -77,8 +77,8 @@ You can print out the Kubernetes manifest for the pod that would be created at r

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-01-30 Thread via GitHub
ketozhang commented on PR #37047: URL: https://github.com/apache/airflow/pull/37047#issuecomment-1917580816 Perhaps out of scope. `pod_template_file` and `pod_template_dict` is mutually exclusive. If both are specified then `pod_template_dict` is ignored. This should be in the API docs. -

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-01-30 Thread via GitHub
ketozhang commented on code in PR #37047: URL: https://github.com/apache/airflow/pull/37047#discussion_r1471693809 ## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ## @@ -77,8 +77,8 @@ You can print out the Kubernetes manifest for the pod that would be created at

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-01-30 Thread via GitHub
dirrao commented on code in PR #37047: URL: https://github.com/apache/airflow/pull/37047#discussion_r1471103997 ## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ## @@ -77,8 +77,8 @@ You can print out the Kubernetes manifest for the pod that would be created at r

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-01-29 Thread via GitHub
ketozhang commented on code in PR #37047: URL: https://github.com/apache/airflow/pull/37047#discussion_r1470039181 ## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ## @@ -77,8 +77,8 @@ You can print out the Kubernetes manifest for the pod that would be created at

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-01-28 Thread via GitHub
amoghrajesh commented on code in PR #37047: URL: https://github.com/apache/airflow/pull/37047#discussion_r1468895610 ## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ## @@ -77,8 +77,8 @@ You can print out the Kubernetes manifest for the pod that would be created

Re: [PR] Fix KPO docs argument precedence [airflow]

2024-01-27 Thread via GitHub
boring-cyborg[bot] commented on PR #37047: URL: https://github.com/apache/airflow/pull/37047#issuecomment-1913480028 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Fix KPO docs argument precedence [airflow]

2024-01-27 Thread via GitHub
ketozhang opened a new pull request, #37047: URL: https://github.com/apache/airflow/pull/37047 closes: #35969 --- Fixes the Argument precedence section of KPO docs. Removed incorrect mention of KPO creates pods based off the Airflow connection. It should