Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-05-31 Thread via GitHub
boring-cyborg[bot] commented on PR #38732: URL: https://github.com/apache/airflow/pull/38732#issuecomment-2142528858 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-05-31 Thread via GitHub
bbovenzi merged PR #38732: URL: https://github.com/apache/airflow/pull/38732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-05-13 Thread via GitHub
RodrigoGanancia commented on PR #38732: URL: https://github.com/apache/airflow/pull/38732#issuecomment-2107277260 Hey, the code is now ready, since the fix is pretty simple I removed the test case which was not needed. I'm sorry for the latest commit, It's my first time contributing and I m

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-05-10 Thread via GitHub
RodrigoGanancia commented on code in PR #38732: URL: https://github.com/apache/airflow/pull/38732#discussion_r1596853665 ## airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx: ## @@ -242,21 +243,23 @@ const ClearInstance = ({ useKeysPress(keyboardSho

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-04-06 Thread via GitHub
RodrigoGanancia commented on code in PR #38732: URL: https://github.com/apache/airflow/pull/38732#discussion_r1554632631 ## airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx: ## @@ -242,21 +243,23 @@ const ClearInstance = ({ useKeysPress(keyboardSho

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-04-04 Thread via GitHub
bbovenzi commented on code in PR #38732: URL: https://github.com/apache/airflow/pull/38732#discussion_r1552026146 ## airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx: ## @@ -242,21 +243,23 @@ const ClearInstance = ({ useKeysPress(keyboardShortcutId

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-04-03 Thread via GitHub
boring-cyborg[bot] commented on PR #38732: URL: https://github.com/apache/airflow/pull/38732#issuecomment-2035996519 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-04-03 Thread via GitHub
RodrigoGanancia opened a new pull request, #38732: URL: https://github.com/apache/airflow/pull/38732 closes: #37451 This bug adresses a visual issue occuring when attempting to mark task states as Failed or Sucess, or when using clear button without the 'can edit o