[PR] Fix ODBC Hook sql select return empty table [airflow]

2024-01-10 Thread via GitHub
roel-w opened a new pull request, #36709: URL: https://github.com/apache/airflow/pull/36709 When querying using a select statement with the odbc hook and the return is an empty table (sqlalchemy []). ```python File "/usr/local/lib/python3.9/site-packages/airflow/prov

Re: [PR] Fix ODBC Hook sql select return empty table [airflow]

2024-01-10 Thread via GitHub
boring-cyborg[bot] commented on PR #36709: URL: https://github.com/apache/airflow/pull/36709#issuecomment-1884508050 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

Re: [PR] Fix ODBC Hook sql select return empty table [airflow]

2024-01-10 Thread via GitHub
Lee-W commented on code in PR #36709: URL: https://github.com/apache/airflow/pull/36709#discussion_r1447188723 ## tests/providers/odbc/hooks/test_odbc.py: ## @@ -329,6 +329,25 @@ def mock_handler(*_): result = hook.run("SQL", handler=mock_handler) assert ho

Re: [PR] Fix ODBC Hook sql select return empty table [airflow]

2024-01-10 Thread via GitHub
Lee-W commented on code in PR #36709: URL: https://github.com/apache/airflow/pull/36709#discussion_r1447188723 ## tests/providers/odbc/hooks/test_odbc.py: ## @@ -329,6 +329,25 @@ def mock_handler(*_): result = hook.run("SQL", handler=mock_handler) assert ho

Re: [PR] Fix ODBC Hook sql select return empty table [airflow]

2024-01-10 Thread via GitHub
potiuk merged PR #36709: URL: https://github.com/apache/airflow/pull/36709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix ODBC Hook sql select return empty table [airflow]

2024-01-10 Thread via GitHub
boring-cyborg[bot] commented on PR #36709: URL: https://github.com/apache/airflow/pull/36709#issuecomment-1885442442 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.