eladkal commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1767148723
Removing milestone as this is provider code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1766902266
Merged. thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk merged PR #34782:
URL: https://github.com/apache/airflow/pull/34782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
JonnyWaffles commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1766887735
Apologies friends! I tried to rebase/merge via Git UI after your approvals.
Not sure what other action I need to take. New to your process. Is there
anything else I need to do to m
JonnyWaffles commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1765011741
It looks like the test kit
[uses](https://github.com/apache/airflow/blob/ad15af5cab6fc7aebb10d194fd5ca28a5e185492/tests/providers/celery/executors/test_celery_executor.py#L71)
the
potiuk commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1758908356
BTW. I still do not understand how "worker" could be affected but at least
this fix might fix the liveness probe issue mentioned in
https://github.com/apache/airflow/issues/34612#issueco
potiuk commented on code in PR #34782:
URL: https://github.com/apache/airflow/pull/34782#discussion_r1356050515
##
airflow/providers/celery/executors/celery_executor_utils.py:
##
@@ -60,16 +60,26 @@
TaskInstanceInCelery = Tuple[TaskInstanceKey, CommandType, Optional[str],
potiuk commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1758902407
> I wonder if we should put the entire `app` initialise logic into a
function and have `app = _get_celery_app()` instead.
Yes. This is better idea. Also `@provider_configuration_lo
uranusjr commented on PR #34782:
URL: https://github.com/apache/airflow/pull/34782#issuecomment-1757350952
I wonder if we should put the entire `app` initialise logic into a function
and have `app = _get_celery_app()` instead.
--
This is an automated message from the Apache Git Service.
T
