Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-02-05 Thread via GitHub
potiuk merged PR #37010: URL: https://github.com/apache/airflow/pull/37010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-02-05 Thread via GitHub
potiuk commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1478438159 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -309,16 +309,19 @@ def __init__( self.labels = labels or {} self.startup_timeout_seconds

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-02-04 Thread via GitHub
romsharon98 commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1477235674 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -309,16 +309,19 @@ def __init__( self.labels = labels or {} self.startup_timeout_se

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-02-03 Thread via GitHub
romsharon98 commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1477124480 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -309,16 +309,19 @@ def __init__( self.labels = labels or {} self.startup_timeout_se

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-01-26 Thread via GitHub
potiuk commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1468017952 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -309,16 +309,19 @@ def __init__( self.labels = labels or {} self.startup_timeout_seconds

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-01-25 Thread via GitHub
romsharon98 commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1466723684 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -245,9 +245,9 @@ def __init__( cmds: list[str] | None = None, arguments: list[str]

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-01-25 Thread via GitHub
dirrao commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1466584846 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -245,9 +245,9 @@ def __init__( cmds: list[str] | None = None, arguments: list[str] | Non

[PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-01-25 Thread via GitHub
romsharon98 opened a new pull request, #37010: URL: https://github.com/apache/airflow/pull/37010 related: #36484 fix: ``` KubernetesPodOperator's constructor lacks direct assignments for instance members corresponding to the following template fields (i.e., self.field_name = field_