Re: [PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
eladkal merged PR #36911: URL: https://github.com/apache/airflow/pull/36911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
romsharon98 commented on code in PR #36911: URL: https://github.com/apache/airflow/pull/36911#discussion_r1459619161 ## airflow/providers/alibaba/cloud/operators/analyticdb_spark.py: ## @@ -113,9 +113,6 @@ class AnalyticDBSparkSQLOperator(AnalyticDBSparkBaseOperator): :par

Re: [PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
Taragolis commented on code in PR #36911: URL: https://github.com/apache/airflow/pull/36911#discussion_r1459310904 ## airflow/providers/alibaba/cloud/operators/analyticdb_spark.py: ## @@ -113,9 +113,6 @@ class AnalyticDBSparkSQLOperator(AnalyticDBSparkBaseOperator): :param

Re: [PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
Taragolis commented on code in PR #36911: URL: https://github.com/apache/airflow/pull/36911#discussion_r1459310904 ## airflow/providers/alibaba/cloud/operators/analyticdb_spark.py: ## @@ -113,9 +113,6 @@ class AnalyticDBSparkSQLOperator(AnalyticDBSparkBaseOperator): :param

[PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
romsharon98 opened a new pull request, #36911: URL: https://github.com/apache/airflow/pull/36911 related: https://github.com/apache/airflow/issues/36484 removed the templated field because it's been run over in the constructor and has no meaning. (this can be cause an issue if someone