Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-01-23 Thread via GitHub
romsharon98 commented on code in PR #36789: URL: https://github.com/apache/airflow/pull/36789#discussion_r1462960112 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -445,9 +445,19 @@ def __init__( self, *, command: Sequence[s

Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-01-26 Thread via GitHub
potiuk commented on code in PR #36789: URL: https://github.com/apache/airflow/pull/36789#discussion_r1468059293 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -445,9 +445,19 @@ def __init__( self, *, command: Sequence[str] =

Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-02-04 Thread via GitHub
Taragolis commented on code in PR #36789: URL: https://github.com/apache/airflow/pull/36789#discussion_r1477259108 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -445,9 +445,19 @@ def __init__( self, *, command: Sequence[str

Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-02-05 Thread via GitHub
potiuk commented on code in PR #36789: URL: https://github.com/apache/airflow/pull/36789#discussion_r1478436450 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -445,9 +445,19 @@ def __init__( self, *, command: Sequence[str] =

Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-02-05 Thread via GitHub
potiuk commented on PR #36789: URL: https://github.com/apache/airflow/pull/36789#issuecomment-1928355344 Conflicts need resolving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-02-06 Thread via GitHub
romsharon98 commented on code in PR #36789: URL: https://github.com/apache/airflow/pull/36789#discussion_r1481014955 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -445,9 +445,19 @@ def __init__( self, *, command: Sequence[s

Re: [PR] Fix assignment of template field in `__init__` in `custom_job` [airflow]

2024-02-07 Thread via GitHub
potiuk merged PR #36789: URL: https://github.com/apache/airflow/pull/36789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a