potiuk merged PR #35048:
URL: https://github.com/apache/airflow/pull/35048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
uranusjr commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1401760020
##
airflow/utils/log/secrets_masker.py:
##
@@ -276,14 +276,15 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
r
Usiel commented on PR #35048:
URL: https://github.com/apache/airflow/pull/35048#issuecomment-1822345282
It's been a while! 😄 Rebased on the latest `main` and happy to continue to
work on this if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message
Usiel commented on PR #35048:
URL: https://github.com/apache/airflow/pull/35048#issuecomment-1784750005
Rebased on `main`, incorporated the suggestion by @Taragolis (not to filter
the warning log) and added the suggested fix for the underlying bug that
brought me here: str-like class with c
uranusjr commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1368256292
##
airflow/utils/log/secrets_masker.py:
##
@@ -279,9 +279,9 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
# but it ca
uranusjr commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1368256292
##
airflow/utils/log/secrets_masker.py:
##
@@ -279,9 +279,9 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
# but it ca
Usiel commented on PR #35048:
URL: https://github.com/apache/airflow/pull/35048#issuecomment-1774472877
> I think the also problem here with inheritance of builtin type `str`, with
`collections.UserString` there is no recursion error, except the fact that
there is no masking secrets in this
Usiel commented on PR #35048:
URL: https://github.com/apache/airflow/pull/35048#issuecomment-1774471133
> This feels a bit too fragile to me; it is much too easy for new code to
introduce a logging call that hits the errornous code path again. Is it
possible to fix this in the log rendering
utkarsharma2 commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1365832533
##
airflow/utils/log/secrets_masker.py:
##
@@ -279,9 +279,9 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
# but i
Taragolis commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1365166781
##
airflow/utils/log/secrets_masker.py:
##
@@ -279,9 +279,9 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
# but it c
Taragolis commented on PR #35048:
URL: https://github.com/apache/airflow/pull/35048#issuecomment-1770290706
I think the also problem here with inheritance of builtin type `str`, with
`collections.UserString` there is no recursion error, except the fact that
there is no masking secrets in th
uranusjr commented on PR #35048:
URL: https://github.com/apache/airflow/pull/35048#issuecomment-1770238763
This feels a bit too fragile to me; it is much too easy for new code to
introduce a logging call that hits the errornous code path again. Is it
possible to fix this in the log renderin
Usiel opened a new pull request, #35048:
URL: https://github.com/apache/airflow/pull/35048
We can get into trouble for text types that cannot be initiated with re2's
`type(obj)()` call. The `secrets_masker` thus fails, which triggers a warning
log, which also fails because we pass the objec
13 matches
Mail list logo
