Re: [PR] Fix import future annotations in docker decorator [airflow]

2024-06-13 Thread via GitHub
phi-friday commented on PR #40208: URL: https://github.com/apache/airflow/pull/40208#issuecomment-2167011779 Changed the location, as it affects venv operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Fix import future annotations in docker decorator [airflow]

2024-06-13 Thread via GitHub
phi-friday commented on PR #40208: URL: https://github.com/apache/airflow/pull/40208#issuecomment-2167005287 First, I changed the test to only work with `airflow>=2.10`. But looking at the output, I don't think it's a change to `airflow[docker]`. Should I change the test location an

Re: [PR] Fix import future annotations in docker decorator [airflow]

2024-06-13 Thread via GitHub
potiuk commented on PR #40208: URL: https://github.com/apache/airflow/pull/40208#issuecomment-2166755163 The test will have to be skipped on airflow pre 2.10 because it will not work there (See failing compatibility tests) and ways how to deal with the compatibility issues: https://github.

Re: [PR] Fix import future annotations in docker decorator [airflow]

2024-06-13 Thread via GitHub
phi-friday commented on code in PR #40208: URL: https://github.com/apache/airflow/pull/40208#discussion_r1637835611 ## airflow/utils/python_virtualenv_script.jinja2: ## @@ -16,7 +16,9 @@ specific language governing permissions and limitations under the License. -#} - +{% if

Re: [PR] Fix import future annotations in docker decorator [airflow]

2024-06-12 Thread via GitHub
potiuk commented on code in PR #40208: URL: https://github.com/apache/airflow/pull/40208#discussion_r1637582732 ## airflow/utils/python_virtualenv_script.jinja2: ## @@ -16,7 +16,9 @@ specific language governing permissions and limitations under the License. -#} - +{% if imp

[PR] Fix import future annotations in docker decorator [airflow]

2024-06-12 Thread via GitHub
phi-friday opened a new pull request, #40208: URL: https://github.com/apache/airflow/pull/40208 --- The following `Task`, when rendered as a jinja template, will result in an error because `Any` is not imported ```python from __future__ import annotat