Re: [PR] Fix parsing connection uri which contains a composite protocol sparated by : [airflow]

2023-11-17 Thread via GitHub
dstandish commented on PR #33531: URL: https://github.com/apache/airflow/pull/33531#issuecomment-1817229507 This fix may not be necessary: see comment https://github.com/apache/airflow/issues/33442#issuecomment-1817228790 -- This is an automated message from the Apache Git Service.

Re: [PR] Fix parsing connection uri which contains a composite protocol sparated by : [airflow]

2023-12-06 Thread via GitHub
itstalmeez commented on PR #33531: URL: https://github.com/apache/airflow/pull/33531#issuecomment-1843643505 Resolves issue #33442 by addressing an inconsistency in urlsplit, which fails to correctly parse URLs with colons in the protocol. This PR introduces a workaround by replacing the co

Re: [PR] Fix parsing connection uri which contains a composite protocol sparated by : [airflow]

2023-12-07 Thread via GitHub
uranusjr commented on PR #33531: URL: https://github.com/apache/airflow/pull/33531#issuecomment-1845908403 https://www.rfc-editor.org/rfc/rfc3986#section-3.1 ~~~ scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ) ~~~ Having a colon in the scheme makes the URI invalid

Re: [PR] Fix parsing connection uri which contains a composite protocol sparated by : [airflow]

2023-12-07 Thread via GitHub
dstandish commented on PR #33531: URL: https://github.com/apache/airflow/pull/33531#issuecomment-1845917794 See, for example, ODBC hook, which allows you to specify the sqlalchemy scheme with `sqlalchemy_scheme`, either as hook init param, or as a connection extra. -- This is an automate

Re: [PR] Fix parsing connection uri which contains a composite protocol sparated by : [airflow]

2024-08-04 Thread via GitHub
github-actions[bot] closed pull request #33531: Fix parsing connection uri which contains a composite protocol sparated by : URL: https://github.com/apache/airflow/pull/33531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us