Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-06 Thread via GitHub
Taragolis merged PR #35339: URL: https://github.com/apache/airflow/pull/35339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
syedahsn commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379087446 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
Taragolis commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379072906 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
Taragolis commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379070387 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
syedahsn commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379067138 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
Taragolis commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379067692 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
Taragolis commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379061352 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

Re: [PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
syedahsn commented on code in PR #35339: URL: https://github.com/apache/airflow/pull/35339#discussion_r1379043315 ## airflow/utils/cli.py: ## @@ -269,7 +269,7 @@ def get_dag_by_pickle(pickle_id: int, session: Session = NEW_SESSION) -> DAG: """Fetch DAG from the database

[PR] Fix query in `get_dag_by_pickle` util function [airflow]

2023-11-01 Thread via GitHub
Taragolis opened a new pull request, #35339: URL: https://github.com/apache/airflow/pull/35339 I'm not sure is it used anywhere, but found that with this kind of query this function would always failed with `AttributeError: 'DagPickle' object has no attribute 'first'` or