[PR] Fix service account impersonation with computeEngineSSHHook (google provider) [airflow]

2023-10-23 Thread via GitHub
ginolegigot opened a new pull request, #35136: URL: https://github.com/apache/airflow/pull/35136 Hello ! This PR aims to solve the issue where we can't use service account impersonation when we want to connect with ssh between 2 Google Compute Engine instances. It is a new version o

Re: [PR] Fix service account impersonation with computeEngineSSHHook (google provider) [airflow]

2023-10-23 Thread via GitHub
potiuk commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1775670817 It will need unit test. We rarely accept changes without corresponding unit tests - mostly when they are difficult to write. This one seems quite reasonable. -- This is an automated m

Re: [PR] Fix service account impersonation with computeEngineSSHHook (google provider) [airflow]

2023-10-23 Thread via GitHub
ginolegigot commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1775674632 Roger! I'll try to understand how to write some unit tests in my particular context using airflow tests libs -- This is an automated message from the Apache Git Service. To res

Re: [PR] Fix service account impersonation with computeEngineSSHHook (google provider) [airflow]

2023-10-24 Thread via GitHub
Taragolis commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1778263226 The simplest way have a look how it done in other Google Provider test, for example https://github.com/apache/airflow/blob/6c62985055e7f9a715c3ae47f6ff584ad8378e2a/tests/provid