Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2094360099 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-04 Thread via GitHub
jscheffl merged PR #39345: URL: https://github.com/apache/airflow/pull/39345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-04 Thread via GitHub
jscheffl commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2094360029 Really cool catch. I can immediately see it locally and the UI feels immediately faster with this PR! THANKS! (I think we could debate about the time, 12h sounds reasonable for m

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
VertexToEdge commented on code in PR #39345: URL: https://github.com/apache/airflow/pull/39345#discussion_r1586902396 ## airflow/www/app.py: ## @@ -120,6 +120,10 @@ def create_app(config=None, testing=False): ) cookie_samesite_config = "Lax" flask_app.conf

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on code in PR #39345: URL: https://github.com/apache/airflow/pull/39345#discussion_r1586433872 ## airflow/www/app.py: ## @@ -120,6 +120,10 @@ def create_app(config=None, testing=False): ) cookie_samesite_config = "Lax" flask_app.config[

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
bbovenzi commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2088631413 Nice catch! We could probably cache it for a few weeks. Assets will only change between airflow version updates. -- This is an automated message from the Apache Git Service. To respo

[PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
VertexToEdge opened a new pull request, #39345: URL: https://github.com/apache/airflow/pull/39345 close #39344 Above Airflow 2.3.0, webserver's static file caching is disabled because of major updated Flask's breaking change. In Flask 2.0.x, default value of `SEND_FILE_M

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
boring-cyborg[bot] commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2088394243 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'