[PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
sunank200 opened a new pull request, #39688: URL: https://github.com/apache/airflow/pull/39688 The upstream `pinecone-client>=3.0.0` accepts vector as `Union[List[Vector], List[tuple], List[dict]]` as per [https://github.com/pinecone-io/pinecone-python-client/blob/main/pinecone/

Re: [PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
utkarsharma2 commented on code in PR #39688: URL: https://github.com/apache/airflow/pull/39688#discussion_r1605252501 ## airflow/providers/pinecone/operators/pinecone.py: ## @@ -52,7 +52,7 @@ def __init__( *, conn_id: str = PineconeHook.default_conn_name,

Re: [PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
utkarsharma2 commented on code in PR #39688: URL: https://github.com/apache/airflow/pull/39688#discussion_r1605261158 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -24,7 +24,7 @@ from functools import cached_property from typing import TYPE_CHECKING, Any -from pinec

Re: [PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
utkarsharma2 commented on code in PR #39688: URL: https://github.com/apache/airflow/pull/39688#discussion_r1605261683 ## airflow/providers/pinecone/operators/pinecone.py: ## @@ -21,7 +21,7 @@ from typing import TYPE_CHECKING, Any, Sequence from airflow.models import BaseOper

Re: [PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
sunank200 commented on code in PR #39688: URL: https://github.com/apache/airflow/pull/39688#discussion_r1605271233 ## airflow/providers/pinecone/operators/pinecone.py: ## @@ -52,7 +52,7 @@ def __init__( *, conn_id: str = PineconeHook.default_conn_name,

Re: [PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
sunank200 commented on code in PR #39688: URL: https://github.com/apache/airflow/pull/39688#discussion_r1605271881 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -24,7 +24,7 @@ from functools import cached_property from typing import TYPE_CHECKING, Any -from pinecone

Re: [PR] Fix the argument type of input_vectors in pinecone upsert [airflow]

2024-05-17 Thread via GitHub
utkarsharma2 merged PR #39688: URL: https://github.com/apache/airflow/pull/39688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air