Re: [PR] Fix triggerer race condition in HA setting [airflow]

eladkal merged PR #38666: URL: https://github.com/apache/airflow/pull/38666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Fix triggerer race condition in HA setting [airflow]

boring-cyborg[bot] commented on PR #38666: URL: https://github.com/apache/airflow/pull/38666#issuecomment-2144651626 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on PR #38666: URL: https://github.com/apache/airflow/pull/38666#issuecomment-2095107186 @uranusjr Thanks for the approval! I've taken all of your remaining suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1590489425 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,88 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argume

Re: [PR] Fix triggerer race condition in HA setting [airflow]

uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1579076419 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,88 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argum

Re: [PR] Fix triggerer race condition in HA setting [airflow]

uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1579075206 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,88 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argum

Re: [PR] Fix triggerer race condition in HA setting [airflow]

uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1579074035 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,88 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argum

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1564458689 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argum

Re: [PR] Fix triggerer race condition in HA setting [airflow]

uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r124367 ## airflow/jobs/triggerer_job_runner.py: ## @@ -672,6 +672,17 @@ def update_triggers(self, requested_trigger_ids: set[int]): self.failed_triggers.ap

Re: [PR] Fix triggerer race condition in HA setting [airflow]

uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r123455 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argu

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1550668109 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argum

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on PR #38666: URL: https://github.com/apache/airflow/pull/38666#issuecomment-2035826125 Could have sworn I ran pre-commit already... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1550657716 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword argum

Re: [PR] Fix triggerer race condition in HA setting [airflow]

Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1550656016 ## airflow/jobs/triggerer_job_runner.py: ## @@ -672,6 +672,17 @@ def update_triggers(self, requested_trigger_ids: set[int]): self.failed_triggers.app

Re: [PR] Fix triggerer race condition in HA setting [airflow]

uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1547052295 ## airflow/jobs/triggerer_job_runner.py: ## @@ -672,6 +672,17 @@ def update_triggers(self, requested_trigger_ids: set[int]): self.failed_triggers.ap

Re: [PR] Fix triggerer race condition in HA setting [airflow]

boring-cyborg[bot] commented on PR #38666: URL: https://github.com/apache/airflow/pull/38666#issuecomment-2030896627 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Fix triggerer race condition in HA setting [airflow]

Lioscro opened a new pull request, #38666: URL: https://github.com/apache/airflow/pull/38666 closes: #38599 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/0