Satoshi-Sh opened a new pull request, #37555:
URL: https://github.com/apache/airflow/pull/37555
## Description
On this PR, I'm fixing the bugs mentioned in [Attempt to update Connexion
library to version 3
#36052](https://github.com/apache/airflow/pull/36052#:~:te
vincbeck commented on code in PR #37555:
URL: https://github.com/apache/airflow/pull/37555#discussion_r1496007419
##
airflow/cli/commands/internal_api_command.py:
##
@@ -73,8 +73,8 @@ def internal_api(args):
log.info(f"Starting the Internal API server on port {args.port
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1954458046
I just added few comments. The code changes look massive, some changes do
not look related to the PR. Could you please rebase your PR against main?
Also, I think some renaming w
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1954458348
Thanks for picking this effort though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Satoshi-Sh commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1954479310
Thanks for the feedback, Vincebeck. This was my first time to use rebase. I
think I made some mistakes during the process. I will try it with Jarek
tomorrow.
--
This is an autom
Taragolis commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1954868154
> This was my first time to use rebase.
The first time with `git rebase` it ever painful, after that things become
much easier
--
This is an automated message from the Apache
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1954877792
> > This was my first time to use rebase.
>
> The first time with `git rebase` it ever painful, after that things become
much easier
💯
--
This is an automated message
sudiptob2 commented on code in PR #37555:
URL: https://github.com/apache/airflow/pull/37555#discussion_r1499516422
##
airflow/providers/fab/auth_manager/fab_auth_manager.py:
##
@@ -149,19 +150,26 @@ def get_cli_commands() -> list[CLICommand]:
SYNC_PERM_COMMAND, # n
sudiptob2 commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1959967667
Hi @vincbeck
we rebased the branch with `main`. Still, the PR is massive because this PR
is based on [this](https://github.com/apache/airflow/pull/36052) made by
[VladaZakharova](
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1960023426
> Hi @vincbeck we rebased the branch with `main`. Still, the PR is massive
because this PR is based on
[this](https://github.com/apache/airflow/pull/36052) made by
[VladaZakharova](ht
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1960036052
By looking at it, I think the code changes make sense, just the list of
commit does not make sense. As an example I created (and closed this PR) which
contain all your changes and only
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1960036473
But I guess it is fair to ignore, git should handle it when we merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
vincbeck commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1960049511
> Hi @vincbeck we rebased the branch with `main`. Still, the PR is massive
because this PR is based on
[this](https://github.com/apache/airflow/pull/36052) made by
[VladaZakharova](ht
sudiptob2 commented on code in PR #37555:
URL: https://github.com/apache/airflow/pull/37555#discussion_r1499941678
##
airflow/cli/commands/internal_api_command.py:
##
@@ -240,11 +241,11 @@ def create_app(config=None, testing=False):
with flask_app.app_context():
vincbeck commented on code in PR #37555:
URL: https://github.com/apache/airflow/pull/37555#discussion_r1499951957
##
airflow/cli/commands/internal_api_command.py:
##
@@ -240,11 +241,11 @@ def create_app(config=None, testing=False):
with flask_app.app_context():
i
sudiptob2 commented on code in PR #37555:
URL: https://github.com/apache/airflow/pull/37555#discussion_r1499953541
##
airflow/cli/commands/internal_api_command.py:
##
@@ -240,11 +241,11 @@ def create_app(config=None, testing=False):
with flask_app.app_context():
Satoshi-Sh commented on PR #37555:
URL: https://github.com/apache/airflow/pull/37555#issuecomment-1960530583
This PR had an issue with rebasing. We moved to #37638 instead of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Satoshi-Sh closed pull request #37555: Fixing Errors (Update Connexion Library
to version 3)
URL: https://github.com/apache/airflow/pull/37555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
18 matches
Mail list logo
