[PR] Fixing status icon alignment for various views [airflow]

2024-01-15 Thread via GitHub
amoghrajesh opened a new pull request, #36804: URL: https://github.com/apache/airflow/pull/36804 In lines to https://github.com/apache/airflow/issues/36574, there was a slight misalignment even in the status icon. Since `Box` prop doesn't accept the style argument, fixed it

Re: [PR] Fixing status icon alignment for various views [airflow]

2024-01-15 Thread via GitHub
amoghrajesh commented on PR #36804: URL: https://github.com/apache/airflow/pull/36804#issuecomment-1893048552 @bbovenzi @pierrejeambrun can you help in a review here when you have some time? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fixing status icon alignment for various views [airflow]

2024-01-24 Thread via GitHub
amoghrajesh commented on PR #36804: URL: https://github.com/apache/airflow/pull/36804#issuecomment-1907929883 @bbovenzi can you take a look at this when you have some time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Fixing status icon alignment for various views [airflow]

2024-01-25 Thread via GitHub
pierrejeambrun commented on PR #36804: URL: https://github.com/apache/airflow/pull/36804#issuecomment-1910097338 I don't think that manually translating by 2 px is the way to go. (That might not work on every browser, screen size etc...). Just using the flex property of the Box should be en

Re: [PR] Fixing status icon alignment for various views [airflow]

2024-01-29 Thread via GitHub
amoghrajesh commented on PR #36804: URL: https://github.com/apache/airflow/pull/36804#issuecomment-1916051280 > I don't think that manually translating by 2 px is the way to go, this is hacky. (That might not work on every browser, screen size etc...). Just using the flex property of the Bo

Re: [PR] Fixing status icon alignment for various views [airflow]

2024-01-29 Thread via GitHub
amoghrajesh commented on PR #36804: URL: https://github.com/apache/airflow/pull/36804#issuecomment-1916059253 @pierrejeambrun I made the changes using flex of Box, results look the same now: ![image](https://github.com/apache/airflow/assets/35884252/d3f819c4-36bc-4373-98f8-78b9488c632f)

Re: [PR] Fixing status icon alignment for various views [airflow]

2024-01-29 Thread via GitHub
amoghrajesh commented on PR #36804: URL: https://github.com/apache/airflow/pull/36804#issuecomment-1916066467 Oops, that was a bad rebase, removed all reviewers who got added due to it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to