Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-10-11 Thread via GitHub
RNHTTR commented on code in PR #42005: URL: https://github.com/apache/airflow/pull/42005#discussion_r1797362428 ## airflow/models/baseoperator.py: ## @@ -909,6 +909,7 @@ def __init__( task_display_name: str | None = None, logger_name: str | None = None,

Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-10-11 Thread via GitHub
MRLab12 commented on code in PR #42005: URL: https://github.com/apache/airflow/pull/42005#discussion_r1797192492 ## airflow/models/baseoperator.py: ## @@ -909,6 +909,7 @@ def __init__( task_display_name: str | None = None, logger_name: str | None = None,

Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-10-11 Thread via GitHub
ashb commented on code in PR #42005: URL: https://github.com/apache/airflow/pull/42005#discussion_r1797105266 ## airflow/models/baseoperator.py: ## @@ -909,6 +909,7 @@ def __init__( task_display_name: str | None = None, logger_name: str | None = None,

Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-09-17 Thread via GitHub
MRLab12 commented on PR #42005: URL: https://github.com/apache/airflow/pull/42005#issuecomment-2357090849 @RNHTTR Checking in here, have you gotten a chance to look at these changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-09-04 Thread via GitHub
MRLab12 closed pull request #42002: Implement on_killed support for tasks during DAG run timeout URL: https://github.com/apache/airflow/pull/42002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-09-04 Thread via GitHub
MRLab12 opened a new pull request, #42002: URL: https://github.com/apache/airflow/pull/42002 --- *This is a new PR to fix an issue with the Tests workflow (old [PR](https://github.com/apache/airflow/pull/41627)) This PR addresses issue #41036 by addi

Re: [PR] Implement `on_killed` support for tasks during DAG run timeout [airflow]

2024-09-03 Thread via GitHub
MRLab12 closed pull request #41627: Implement `on_killed` support for tasks during DAG run timeout URL: https://github.com/apache/airflow/pull/41627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Implement `on_killed` support for tasks during DAG run timeout [airflow]

2024-08-29 Thread via GitHub
eladkal commented on code in PR #41627: URL: https://github.com/apache/airflow/pull/41627#discussion_r1735730223 ## airflow/api_connexion/schemas/dag_schema.py: ## @@ -113,6 +113,7 @@ class DAGDetailSchema(DAGSchema): template_searchpath = fields.String(dump_only=True)

Re: [PR] Implement `on_killed` support for tasks during DAG run timeout [airflow]

2024-08-28 Thread via GitHub
MRLab12 commented on PR #41627: URL: https://github.com/apache/airflow/pull/41627#issuecomment-2316105127 Apologies for the merge mess! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Implement `on_killed` support for tasks during DAG run timeout [airflow]

2024-08-20 Thread via GitHub
MRLab12 commented on PR #41627: URL: https://github.com/apache/airflow/pull/41627#issuecomment-2299777200 I'm having some issues with the test I added. Looking at other tests in `test_scheduler_job` I see that `session.refresh(dr)` is used before asserting the dag run state. In my test it c

[PR] Implement `on_killed` support for tasks during DAG run timeout [airflow]

2024-08-20 Thread via GitHub
MRLab12 opened a new pull request, #41627: URL: https://github.com/apache/airflow/pull/41627 --- This PR addresses issue #41036 by adding support for the `on_killed` callback on tasks that are still running when a DAG run reaches its timeout. Key cha