eladkal merged PR #36171:
URL: https://github.com/apache/airflow/pull/36171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
eladkal commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1896051684
:tada: :tada::tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
flolas commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1895715074
@eladkal Tests seems good now 👍 , can you review again the code? I made some
changes to address @Taragolis comments.
--
This is an automated message from the Apache Git Service.
To res
flolas commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1892656544
> I can see:
>
> ```
> File path:
apache-airflow-providers-celery/_api/airflow/providers/celery/executors/celery_kubernetes_executor/index.rst
> Incorrect Spelling: 'taskinst
vincbeck commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1892651676
I can see:
```
File path:
apache-airflow-providers-celery/_api/airflow/providers/celery/executors/celery_kubernetes_executor/index.rst
Incorrect Spelling: 'taskinstancekey'
flolas commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1892646366
@eladkal Ummh, I can't figure out why spellcheck test fails with errors like
this:
```
apache-airflow-providers-celery Traceback
(most recent call la
eladkal commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1890858035
@flolas what is the status of this PR? I'm hoping to get it to the next
peovider release.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1432173552
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1432173384
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1432168649
##
docs/apache-airflow-providers-amazon/operators/athena.rst:
##
Review Comment:
@Taragolis the spellcheck error is in **apache-airflow-providers**, not in
**apa
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1432168649
##
docs/apache-airflow-providers-amazon/operators/athena.rst:
##
Review Comment:
@Taragolis the spellcheck error is in **apache-airflow-providers**, not in
**apa
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1432023328
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
vincbeck commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1431640078
##
docs/apache-airflow-providers-amazon/operators/athena.rst:
##
Review Comment:
Interesting. Alright, looks right you're right then :)
--
This is an automa
Taragolis commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1431631713
##
docs/apache-airflow-providers-amazon/operators/athena.rst:
##
Review Comment:
This is a different problems here:
1. Redirect and existed document in the
vincbeck commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1431602833
##
docs/apache-airflow-providers-amazon/operators/athena.rst:
##
Review Comment:
See this comment :)
https://github.com/apache/airflow/pull/36171#issuecomment-
Taragolis commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1431316859
##
tests/providers/amazon/aws/hooks/test_athena_sql.py:
##
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
simonprydden commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1862083934
Will this work with AWS credentials provider chain? I'm thinking about mwaa
environments where the aws_default conn_id is used for most aws hooks.
--
This is an automated message
vincbeck commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1861700849
It seems, Sphinx has some issues referencing a document not built yet. See
https://apache-airflow.slack.com/archives/CJ1LVREHX/p1702929226260749. In other
words, here you are creating
vincbeck commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1860587366
Interesting, I have a very similar error message in my open PRs and cannot
figure out why. I am very interested if someones knows the reason
--
This is an automated message from the
vincbeck commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1860585718
```
apache-airflow-providers
apache-airflow-providers Traceback
(most recent call last):
apache-air
flolas commented on PR #36171:
URL: https://github.com/apache/airflow/pull/36171#issuecomment-1860460955
@eladkal could you help me with the spellcheck test? can't find what's
wrong. thx!
https://github.com/apache/airflow/actions/runs/7247473202/job/19742207009?pr=36171
--
This is an
eladkal commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1427937963
##
docs/apache-airflow-providers-amazon/operators/athena/index.rst:
##
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more c
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1427917066
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,103 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1427911376
##
docs/apache-airflow-providers-amazon/operators/athena/index.rst:
##
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more co
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1427903717
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,103 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
flolas commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1427899167
##
docs/apache-airflow-providers-amazon/connections/athena.rst:
##
@@ -0,0 +1,45 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contri
eladkal commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1427842314
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,103 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
josh-fell commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1424797740
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
Taragolis commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1423810761
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
Taragolis commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1423802816
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
vincbeck commented on code in PR #36171:
URL: https://github.com/apache/airflow/pull/36171#discussion_r1422892078
##
airflow/providers/amazon/aws/hooks/athena_sql.py:
##
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licens
flolas opened a new pull request, #36171:
URL: https://github.com/apache/airflow/pull/36171
In this Pull Request, we're introducing the `AthenaSQLHook`, an
implementation leveraging PyAthena. This development opens doors for us to
interact with Athena using the familiar DBApiHook operators.
32 matches
Mail list logo
